On Wed, Aug 03, 2011 at 09:47:42AM +0200, Jindřich Makovička wrote:
> as Kevin Baradon noted, the patch that was finally applied is useless
> (at least regarding this bug) - the message is produced by
> /usr/bin/invoke-rc.d and still appears.

If invoke-rc.d is spitting out a spurious warning message, that should be
fixed in invoke-rc.d; please file a separate bug for that.

> If you do not want to leak PIDs to dhcp hooks, I'd recommend using the
> same runlevel check as in invoke-rc.d (see patch).

> --- samba.orig        2011-03-07 20:28:32.000000000 +0100
> +++ samba     2011-08-03 09:34:21.559600753 +0200
> @@ -68,7 +68,11 @@
>  
>       # reload the samba server
>       # We don't necessarily have the samba package installed. #414841
> -     [ -x /etc/init.d/samba ] && /usr/sbin/invoke-rc.d samba reload
> +     # Also, do not invoke reload on shutdown
> +     RL=`runlevel | sed 's/.*\ //'`
> +     if test x${RL} != x0 && test x${RL} != x6 ; then
> +             [ -x /etc/init.d/samba ] && /usr/sbin/invoke-rc.d samba reload
> +     fi
>  
>  }
>  

Nack.  Wrong place to fix this.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to