-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hello,
Am Mi den 10. Aug 2011 um 15:59 schrieb Christian Kastner: > On 08/10/2011 12:43 PM, Klaus Ethgen wrote: > > The solution of #609780 breaks all log analysing tools. > > First, it most certainly does not break "all" log analyzing tools. Most > notably, logcheck works fine with this solution. Please provide some > specific examples of such tools so that we may better form our opinion. > If it really breaks a lot of tools we might revert it. Am Do den 11. Aug 2011 um 0:38 schrieb Javier Fern?ndez-Sanguino Pe?a: > Breaks "all" seems rather harsh (and untrue, we did review logcheck). Anyway, > if a log analysing tool breaks because of this change you should bug *them*, > not us. The cron log format is not set on stone and (in Debian) they will > have until the next release to adapt. Well, You may checked logcheck but not logwatch. In logwatch the lines are summarised. With the PID twice in the file that cannot be done anymore. Also all other tools that relies on a more ore less constant message for the same think, not related if they are "official" or hand written, will not work anymore. > Please bear in mind that this is Debian's unstable, and our interest > is to improve CRON not to keep log analysis tools happy. Well, that is clear. But also in sid this is a bug. And you might have seen that I tagged the bug "normal" and not "grave" as it would be breaking other applications. Am Mi den 10. Aug 2011 um 15:59 schrieb Christian Kastner: > > More over it makes no sense to log the PID twice in the logs. [...] > The reason #609780 was re-opened is precisely because it is *not* the > same PID twice. I checked twice in my log file and all entries from cron have the same PID twice in the same line. So there is never a difference and this message is unusable at all. > The start message "CMD" is logged by the fork()ed child before it > exec()s, the end message "END" by the parent. Therefore the syslog PID > is always at least off-by-one. I have no message in the file about an end. There is only the line with the CMD in the file. Am Do den 11. Aug 2011 um 0:38 schrieb Javier Fern?ndez-Sanguino Pe?a: > > In logfiles the PID is expected direct behind the binary and is recorded > > by the syslog (The PID is part of syslog protocol). Putting the same PID > > in the message do not only add redundancy that is not needed, it breaks > > other tools too as log analysing tools or intrusion detection systems. > > You don't seem to have read the bug report that motivate the change and you > don't seem to understand the change fully either. I had. But there is no sense for me to add such information. However, I believe that there _is_ for _some_ people. But then please make this configurable and not on by default. For me this additional (same) PID is boring, broken, unuseful and makes lot of troubles that I might overlooked the real important messages in my log summary. > > Please revoke that broken patch. > > We will not "revoke" that patch. Uh. Please calm down. I please you to do not ordered. > We might adjust it to avoid redundant information (for the 'CMD' call > at least) but it is certainly our intention to keep the change. To revoke a patch and make it new and not broken is no bad solution. It is common in software development. This particular patch is broken. And as such has to be revoked in my eyes. That do not include that a revoked patch that is more smooth cannot be added in future. Regards Klaus - -- Klaus Ethgen http://www.ethgen.ch/ pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen <kl...@ethgen.de> Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQGcBAEBCgAGBQJOQ5VuAAoJEK8RO3RE9oVxwMoL/06xiJQh8GNAEyYsrg6idF1Q j4DE8Mf6uDO+zQiRaYpc8+o+IF1klybnZczzIIW7xL+Fz79qptmaFNaOF6wBECEk NLR8G02oiNHV/8JTetOf8HzRVvbl3lYYeSL19XL59z/WW8td5lfH3NeD6PLQbU1a 3kXhx9QCbPiH3jPS4XKsV5xZWkHVLYY4uYbIoT2V3MhfgUgLst4gsI1dt3o6z95h oWlMuJEsdrDim/OKfz9s4KvNcSnHVIw1VAF5+4EEPsTikpjU6AGt5+f8IjYxFtlU 6O+FE7cOdWmKciEpVJXzFOm083Y7QD1bvlBosGvAhZ9vraajnh9jiajhjtXeLTZO +5fuE0MvXoh9HY5/FixCRfdFkLJFVbAkaXfqRlQBbYNXEr+urnXTqNNeYDvLrq6f zWNIXXcREe0bC7vC84YxF3+/wvC1Qhc7VBggAFlrCVwZBzWayfIrbGaO+k6hNTch QrHpoYItyTt24669igUQoc9a2/oM4Tdw1WvZUHUtzw== =Tpy3 -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
