On 28/08/2011 15:35, Giuseppe Iuculano wrote:
> On 08/28/2011 03:31 PM, Jérémy Lal wrote:
>> Shouldn't the solution be to move v8::internal::I18NExtension::get() to v8
>> (not internal) namespace ?
>
> Yes, but I suspect there are a lot of v8::internal() needed by chromium.
>
> Cheers,
> Giuseppe.
v8 3.4.14.13-3 is patched so that i18n extension is moved to its own namespace
(v8_i18n)
following the externalization of that extension as done for chromium 15.
chromium 14 needs a small patch so it uses the right namespace, see attached.
I am currently building it to check that all is well, and will keep you
informed.
Regards,
Jérémy
--- a/src/third_party/WebKit/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
+++ b/src/third_party/WebKit/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
@@ -368,8 +368,8 @@
#if ENABLE(JAVASCRIPT_I18N_API)
// Enables experimental i18n API in V8.
- if (RuntimeEnabledFeatures::javaScriptI18NAPIEnabled() && !V8Proxy::registeredExtensionWithV8(v8::internal::I18NExtension::get()))
- V8Proxy::registerExtension(v8::internal::I18NExtension::get());
+ if (RuntimeEnabledFeatures::javaScriptI18NAPIEnabled() && !V8Proxy::registeredExtensionWithV8(v8_i18n::I18NExtension::get()))
+ V8Proxy::registerExtension(v8_i18n::I18NExtension::get());
#endif
// Dynamically tell v8 about our extensions now.
