Package: e2fslibs
Version: 1.41.12-4stable1
Severity: normal
File: /lib/libe2p.so.2
Tags: upstream patch
There's an off-by-one bug in lib/e2p/mntopts.c:e2p_string2mntopt(), both
in the Debian 1.41.12 version, and the current upstream 1.41.14
version. It's failing to properly recognize any MNTOPT_* options, which
means I can't for example do the following:
# tune2fs -o MNTOPT_10 /dev/sda2
tune2fs 1.41.12 (17-May-2010)
Invalid mount option set: MNTOPT_10
MNTOPT_10 corresponds to the "discard" mount option; this particular
example is from an embedded system running Debian 6.0.2 armv5tel. Any
other numerical option will fail, not just 10. This affects all
architectures; I am only using this system to report the bug since it is
my mailhub.
I have already tracked down the issue and have just sent a patch
upstream. However, it would be very nice to backport the fix to the
Debian version, so tune2fs's -o feature works as expected...
I am including a patch below to solve the problem. Please backport.
-- System Information:
Debian Release: 6.0.2
APT prefers stable
APT policy: (700, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.18-028stab091.2 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages e2fslibs depends on:
ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib
e2fslibs recommends no packages.
e2fslibs suggests no packages.
-- no debconf information
*** e2fsprogs-1.41.12-debian-numeric-mntopt.patch
2011-09-15 Israel G. Lugo <israel.l...@lugosys.com>
* lib/e2p/mntopt.c: Fix tune2fs never recognizing any MNTOPT_* mount
options, due to off-by-one error in e2p_string2mntopt.
diff -durp e2fsprogs-1.41.12/lib/e2p/mntopts.c
e2fsprogs-1.41.12-debian-numeric-mntopt/lib/e2p/mntopts.c
--- e2fsprogs-1.41.12/lib/e2p/mntopts.c 2011-06-18 19:14:54.000000000 +0200
+++ e2fsprogs-1.41.12-debian-numeric-mntopt/lib/e2p/mntopts.c 2011-09-15
03:59:40.000000000 +0200
@@ -61,7 +61,7 @@ int e2p_string2mntopt(char *string, unsi
return 0;
}
}
- if (strncasecmp(string, "MNTOPT_", 8))
+ if (strncasecmp(string, "MNTOPT_", 7))
return 1;
if (string[8] == 0)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
