On Wed, 21 Sep 2011 16:26:49 jari wrote:
> On 2011-09-21 09:13, jari wrote:
> | On 2011-09-21 09:50, Con Kolivas wrote:
> | | On Wed, 21 Sep 2011 09:37:35 you wrote:
> | | > Package: lrzip
> | | > Version: 0.607+20110917+git79c2e9a-2
> | | > Severity: important
> | | > Tags: patch
> | | > User: debian-h...@lists.debian.org
> | | > Usertags: hurd
> | | > 
> | | > Hi,
> | | > 
> | | > currently[1], lrzip does not compile on GNU/Hurd.
> | | > This is because it is not configured to use a fake mremap function,
> | | > so it is being used as if it would exist in libc.
> | | > The attached patch enables the use of fake_mremap as mremap also on
> | | > GNU/Hurd. (Ideally a configure check would do this job?)
> | | > 
> | | > [1]
> | | > https://buildd.debian.org/status/fetch.php?pkg=lrzip&arch=hurd-i386&v
> | | > er=0. 607%2B20110917%2Bgit79c2e9a-2&stamp=1316559794
> | | > 
> | | > Thanks,
> | | 
> | | +       defined(__APPLE__) || defined(__CYGWIN__) || \
> | | +       defined(__GNU__)
> | | 
> | | Wouldn't this also define fake mremap on linux too, which actually does
> | | have mremap?
> | 
> | As the problem is Hurd specific, we want stricter[*]:
> |    __gnu_hurd__
> 
> Ah, I take it back. In the thread later[*]:
> 
>     ‘__GNU__’ is only defined on GNU/Hurd, whereas ‘__GLIBC__’ is defined
> on all GNU variants.
> 
> so the original patch is correct.
> 
> Jari
> 
> [*] http://lists.debian.org/debian-bsd/2010/01/msg00151.html

It turns out mremap is linux specific only so I've inverted the test entirely 
for !linux and pushed the fix to git.

Thanks and Regards,
Con
-- 
-ck



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to