Package: dh-make-perl
Version: 0.19
Severity: important
Tags: patch
running dh-make-perl on Hook-Heckle-0.01.01 results in:
Cannot use internal module data to gather the version; use --cpan or \
--version
In extract_name_ver_from_makefile, VERSION_FROM is only parsed from
Makefile.PL if VERSION is also defined in that file.
Hook::Heckle only has VERSION_FROM defined, and the MakeMaker docs seem
to indicate that's a typical situation.
Patch adds code to parse VERSION_FROM into $vfrom even if VERSION is not
defined. It works fine with the patch.
I'm not sure if the VERSION_FROM parsing within the VERSION testing is
still needed or not, so I didn't touch that.
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (900, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages dh-make-perl depends on:
ii debhelper 4.9.8 helper programs for debian/rules
ii dpkg-dev 1.13.11 package building tools for Debian
ii fakeroot 1.5.1 Gives a fake root environment
ii libmodule-depends-perl 0.10-1 identify the dependencies of a dis
ii libyaml-perl 0.38-2 YAML Ain't Markup Language (tm)
ii make 3.80-11 The GNU version of the "make" util
ii perl 5.8.7-5 Larry Wall's Practical Extraction
ii perl-modules [libpod-parser-p 5.8.7-5 Core Perl modules
Versions of packages dh-make-perl recommends:
pn apt-file <none> (no description available)
ii libmodule-build-perl 0.26-1 Subclassable and make-independant
-- no debconf information
Index: dh-make-perl-0.19/dh-make-perl
===================================================================
--- dh-make-perl-0.19.orig/dh-make-perl 2005-09-16 16:19:22.000000000 -0400
+++ dh-make-perl-0.19/dh-make-perl 2005-09-16 16:21:23.000000000 -0400
@@ -431,6 +431,10 @@
$vfrom = $4 if
$file =~ /([\'\"]?)VERSION_FROM\1\s*(=>|,)\s*([\'\"]?)(\S+)\3/s;
+ } elsif ($file =~
/([\'\"]?)VERSION_FROM\1\s*(=>|,)\s*([\'\"]?)(\S+)\3/s) {
+ # Regular MakeMaker
+ $vfrom = $4;
+
} elsif ($file =~ /version\((\S+)\)/s) {
# Module::Install
$ver = $1;
