tag 636753 + patch thanks On Fri, 05 Aug 2011 18:51:16 +0100, Dominic Hargreaves wrote:
> Please modify the build system of this package to append $Config{ccflags}
> to CCFLAGS. In most cases this will be by editing Makefile.PL.
Here's a patch to fix this issue.
I'm not uploading the package right now because I get test failures
(on my machine at home, i386 sid cowbuilder; not on a remote headless
amd64):
/usr/bin/make TEST_VERBOSE=1 DISPLAY="" test
make[1]: Entering directory `/tmp/buildd/libpdl-netcdf-perl-4.07'
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(1,
'blib/lib', 'blib/arch')" t/*.t
# Failed test 'puttext 1'
# at t/01-Netcdf3.t line 21.
# Failed test 'Get slice 1'
# at t/01-Netcdf3.t line 144.
# Failed test 'Get slice 2'
# at t/01-Netcdf3.t line 147.
# Failed test 'Get slice 3'
# at t/01-Netcdf3.t line 150.
# Failed test 'chars with unlimited dimension'
# at t/01-Netcdf3.t line 178.
# Failed test 'Getting a slice of a PDL::Char with unlimited dimension'
# at t/01-Netcdf3.t line 181.
# Looks like you failed 6 tests of 44.
t/01-Netcdf3.t ..
1..44
ok 1 - use PDL;
ok 2 - use PDL::NetCDF;
ok 3 - use PDL::Char;
not ok 4 - puttext 1
ok 5 - puttext 2
ok 6 - zeroDim
ok 7 - puttext 3
ok 8 - Dimension redefinition error
ok 9 - PDL::Char 1
ok 10 - PDL::Char 2
ok 11 - Compressed put/get 1
ok 12 - Compressed put/get 2
ok 13 - Compressed put/get 3
ok 14 - Fast open 1
ok 15 - Fast open 2
ok 16 - Re-writing 1
ok 17 - Re-writing 2
ok 18 - 2D put/get 1
ok 19 - 2D put/get 2
ok 20 - Putatt 1
ok 21 - Putatt 2
ok 22 - Putatt 3
ok 23 - Getatt 1
ok 24 - Getatt 2
ok 25 - Putatt text
ok 26 - Badvals 1
ok 27 - Badvals 2
ok 28 - Putslice 1
ok 29 - Putslice PDL::Char 1
ok 30 - Putslice PDL::Char 2
ok 31 - Putslice short 1
ok 32 - Putslice short 2
not ok 33 - Get slice 1
not ok 34 - Get slice 2
not ok 35 - Get slice 3
ok 36 - uncompressed variable
ok 37 - unshuffled variable
ok 38 - Read bogus file
not ok 39 - chars with unlimited dimension
not ok 40 - Getting a slice of a PDL::Char with unlimited dimension
ok 41 - Getting exactly one string from nc with unlimited dimension
ok 42 - adding dimless char variable
ok 43 - adding dimless double variable
ok 44 - close is idempotent
Removing test file bogus.nc
Dubious, test returned 6 (wstat 1536, 0x600)
Failed 6/44 subtests
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06
: :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
`- NP: Bob Dylan: Can't Wait
diff -u libpdl-netcdf-perl-4.07/debian/changelog libpdl-netcdf-perl-4.07/debian/changelog
--- libpdl-netcdf-perl-4.07/debian/changelog
+++ libpdl-netcdf-perl-4.07/debian/changelog
@@ -1,3 +1,12 @@
+libpdl-netcdf-perl (4.07-1.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fix "broken build with perl 5.14: CCFLAGS should include $Config{ccflags},
+ but build does not fail": new patch 020-perl-5.14-ccflags.dpatch: add
+ $Config{ccflags} to CCFLAGS (closes: #636753).
+
+ -- gregor herrmann <[email protected]> Sun, 16 Oct 2011 20:48:25 +0200
+
libpdl-netcdf-perl (4.07-1) unstable; urgency=low
* new upstream version
diff -u libpdl-netcdf-perl-4.07/debian/patches/00list libpdl-netcdf-perl-4.07/debian/patches/00list
--- libpdl-netcdf-perl-4.07/debian/patches/00list
+++ libpdl-netcdf-perl-4.07/debian/patches/00list
@@ -1,0 +2 @@
+020-perl-5.14-ccflags.dpatch
only in patch2:
unchanged:
--- libpdl-netcdf-perl-4.07.orig/debian/patches/020-perl-5.14-ccflags.dpatch
+++ libpdl-netcdf-perl-4.07/debian/patches/020-perl-5.14-ccflags.dpatch
@@ -0,0 +1,20 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 020-perl-5.14-ccflags.dpatch by gregor herrmann <[email protected]>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Add $Config{ccflags} to CCFLAGS to prevent problems with perl 5.14
+## DP: Closes: #636753
+
+@DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' libpdl-netcdf-perl-4.07~/Makefile.PL libpdl-netcdf-perl-4.07/Makefile.PL
+--- libpdl-netcdf-perl-4.07~/Makefile.PL 2010-12-31 00:09:17.000000000 +0100
++++ libpdl-netcdf-perl-4.07/Makefile.PL 2011-10-16 17:42:44.000000000 +0200
+@@ -70,7 +70,7 @@
+ 'NAME' => 'PDL::NetCDF',
+ 'AUTHOR' => 'Douglas Hunt ([email protected])',
+ 'PREREQ_PM' => { PDL => 2.2 },
+- 'CCFLAGS' => "$define_bool -g",
++ 'CCFLAGS' => "$define_bool -g $Config{ccflags}",
+ 'VERSION_FROM' => 'netcdf.pd',
+ 'META_MERGE' => {provides => {PDL::NetCDF => {file => 'netcdf.pd', version => 4.07}}},
+ 'TYPEMAPS' => [&PDL_TYPEMAP()],
signature.asc
Description: Digital signature
