Package: netselect Version: 0.3.ds1-21 Severity: important Tags: patch
An IP header is 20 bytes long, so without __attribute__((packed)) the struct icmp gets padded to a 64 byte boundry, leaving ICMP_TYPE filled in by 0s (ICMP_REPLY). Ideally the packed-on-the-wire data would be separate from the local state information, but that's more work than this trivial fix. -- System Information: Debian Release: 6.0 APT prefers testing APT policy: (700, 'testing'), (650, 'unstable'), (600, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.0.0 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages netselect depends on: ii debconf [debconf-2.0] 1.5.36.1 Debian configuration management sy ii libc6 2.13-10 Embedded GNU C Library: Shared lib netselect recommends no packages. Versions of packages netselect suggests: ii netselect-apt 0.3.ds1-21 speed tester for choosing a fast D -- debconf information: netselect/install-setuid: false
--- netselect.c.orig 2011-10-17 18:17:19.493606775 -0400 +++ netselect.c 2011-10-17 18:16:49.834286886 -0400 @@ -97,7 +97,7 @@ u_char seq; /* sequence number of this packet */ u_char ttl; /* ttl packet left with */ struct timeval tv; /* time packet left */ -} IPacket; +}__attribute__((packed)) IPacket;