tags 646146 + patch
thanks
On 2011-10-21 20:00 +0200, Sven Joachim wrote:
> Package: libphysfs
> Version: 2.0.2-4
> Severity: serious
>
>>From my pbuilder log:
>
> ,----
> | -- Build stdio test program: enabled
> | -- Use readline in test program: enabled
> | CMake Error: The following variables are used in this project, but they are
> set to NOTFOUND.
> | Please set them or make sure they are set and tested correctly in the CMake
> files:
> | CURSES_LIBRARY
> | linked by target "test_physfs" in directory /tmp/buildd/libphysfs-2.0.2
> |
> | -- Configuring incomplete, errors occurred!
> | make: *** [config.status] Error 1
> `----
>
> Either add libncurses-dev to Build-Depends, or (preferably) patch the
> CMakeLists.txt file to not look for a CURSES_LIBRARY, since ncurses is
> _not_ needed for linking against readline.
Debdiff with a patch is attached.
Cheers,
Sven
diff -Nru libphysfs-2.0.2/debian/patches/do_not_link_against_curses.diff
libphysfs-2.0.2/debian/patches/do_not_link_against_curses.diff
--- libphysfs-2.0.2/debian/patches/do_not_link_against_curses.diff
1970-01-01 01:00:00.000000000 +0100
+++ libphysfs-2.0.2/debian/patches/do_not_link_against_curses.diff
2011-11-03 08:49:31.000000000 +0100
@@ -0,0 +1,24 @@
+Description: Do not unnecessarily link against ncurses
+Author: Sven Joachim <[email protected]>
+Bug-Debian: http://bugs.debian.org/646146
+Last-Update: <2011-11-03>
+
+---
+
+--- libphysfs-2.0.2.orig/CMakeLists.txt
++++ libphysfs-2.0.2/CMakeLists.txt
+@@ -300,13 +300,11 @@ IF(PHYSFS_BUILD_TEST)
+ FIND_PATH(READLINE_H readline/readline.h)
+ FIND_PATH(HISTORY_H readline/history.h)
+ IF(READLINE_H AND HISTORY_H)
+- FIND_LIBRARY(CURSES_LIBRARY NAMES curses ncurses)
+- SET(CMAKE_REQUIRED_LIBRARIES ${CURSES_LIBRARY})
+ FIND_LIBRARY(READLINE_LIBRARY readline)
+ FIND_LIBRARY(HISTORY_LIBRARY history)
+ IF(READLINE_LIBRARY AND HISTORY_LIBRARY)
+ SET(HAVE_SYSTEM_READLINE TRUE)
+- SET(TEST_PHYSFS_LIBS ${TEST_PHYSFS_LIBS} ${READLINE_LIBRARY}
${CURSES_LIBRARY})
++ SET(TEST_PHYSFS_LIBS ${TEST_PHYSFS_LIBS} ${READLINE_LIBRARY})
+ INCLUDE_DIRECTORIES(${READLINE_H} ${HISTORY_H})
+ ADD_DEFINITIONS(-DPHYSFS_HAVE_READLINE=1)
+ ENDIF(READLINE_LIBRARY AND HISTORY_LIBRARY)
diff -Nru libphysfs-2.0.2/debian/patches/series
libphysfs-2.0.2/debian/patches/series
--- libphysfs-2.0.2/debian/patches/series 2011-07-19 17:39:11.000000000
+0200
+++ libphysfs-2.0.2/debian/patches/series 2011-11-03 09:10:50.000000000
+0100
@@ -1 +1,2 @@
remove_unused_variable.diff
+do_not_link_against_curses.diff
