Bug#648662: cowbuilder --login ignores --distribution and doesn't pass it to pbuilder

[Nicolas Bonnefon]

Package: cowbuilder
Version: 0.65
Severity: normal
Tags: patch

The --login option passes --override-config down to pbuilder but ignore 
--distribution,
resulting in a /etc/apt/sources.list containing the sources for the host OS.

This is especially a problem when using cowbuilder with cowbuilder-dist because 
it relies on --distribution.

(simple patch attached)

Thanks a lot for this useful package.


N.


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cowbuilder depends on:
ii  cowdancer  0.65   
ii  libc6      2.13-21
ii  pbuilder   0.203  

cowbuilder recommends no packages.

cowbuilder suggests no packages.

-- no debconf information

diff -ru cowdancer-0.65/cowbuilder.c cowdancer-0.65.new//cowbuilder.c
--- cowdancer-0.65/cowbuilder.c2011-07-29 14:01:39.000000000 +0100
+++ cowdancer-0.65.new//cowbuilder.c2011-11-13 19:16:54.356924971 +0000
@@ -447,6 +447,16 @@
   pbuildercommandline[1]=login;
   PBUILDER_ADD_PARAM(--buildplace);
   PBUILDER_ADD_PARAM(pc->buildplace);
+  if (find_matching_param(--override-config))
+    {
+      if (pc->mirror)
+        {
+          PBUILDER_ADD_PARAM(--mirror);
+          PBUILDER_ADD_PARAM(pc->mirror);
+        }
+      PBUILDER_ADD_PARAM(--distribution);
+      PBUILDER_ADD_PARAM(pc->distribution);
+    }
   PBUILDER_ADD_PARAM(--no-targz);
   PBUILDER_ADD_PARAM(--internal-chrootexec);
   PBUILDER_ADD_PARAM(buf_chroot);