Hi Josch,

Johannes Schauer wrote:
> > * Which version of xen-tools do you use?
> xen-tools (4.2.1-1)
> 
> > * Which version of xen are you using?
> xen-hypervisor-4.1-amd64 (4.1.1-3)
> 
> > * Which version of Debian are you using, i.e. Oldstable/Lenny,
> >   Stable/Squeeze, Testing/Wheezy, or Unstable/Sid?
> wheezy

Thanks!

> > Using reportbug (or M-x debian-bug in Emacs if debian-el is installed)
> > automatically answers all these questions.
> 
> sorry, i was reporting from a different machine.

Yeah, I know that case. Including the information manually (as you did
in today's bug report) is fine, too. The package version is important
to see if the bug is perhaps already fixed in newer versions if e.g.
reported against Debian Stable.

> hope this helps!

It does.

> > Some things fixed in xen-create-image seem to be missing in
> > xen-create-nfs. Looks like it needs a bigger cleanup, but that's
> > nothing for a bugfix release.
> 
> xen-create-image would for example also add things like:
> 
> on_poweroff = 'destroy'
> on_reboot   = 'restart'
> on_crash    = 'restart'

Yeah, xen-create-image does way more than xen-create-nfs.

> > For the next bugfix release I'll fix this by copying (*sigh*) the code
> > used for that in xt-create-xen-config (which xen-create-nfs should use
> > but doesn't) to xen-create-nfs.
> 
> maybe there should be a common codebase?

Exactly. The current development team took over the codebase 1.5 years
ago and already cleaned it up a lot, but I just ran over that code
duplication after your bug report. (So I'm really happy about the bug
report. :-) 

I cleaned it up a little bit[1], but neither for now just the less complex
parts and to really fix and not just workaround your issue it needs
some redesign, not just refactoring.

  [1] https://github.com/xtaran/xen-tools/commits/code-deduplication

> xen-create-nfs is really nice and the only thing I had to add to make it
> work was:
> 
> extra = 'boot=nfs root=/dev/nfs'

This looks like it should be added in general. I'll have a look.

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to