Hi Dustin, Thanks for the patch. My review below:
Dustin Kirkland <kirkl...@ubuntu.com> writes: > The postinst part should be pretty simple/clean. I suspect it's also incorrect. In a normal upgrade scenario the preinst first moves tmux-cleanup to tmux-cleanup.dpkg-remove, so the test you added in postinst cannot match. As a result, the dpkg-maintscript-helper call is skipped, which leaves the .dpkg-remove file behind. > The bash completion bit I solved with a symlink from > /etc/bash_completion.d/tmux to the completion script in the docs > location. It looks like most of the other bash completion scripts are > technically conffiles (which seems silly to me), so perhaps you want to > handle this differently. I see at least two reasons not to do it this way: 1) some people drop /usr/share/doc using dpkg path filters on space-constrained systems, and 2) debhelper automatically compresses files larger than 4KB under /usr/share/doc so if the file ever grows past that, it will break. The latter could be worked around, but I'd rather just not have to deal with bash completion at all. What's the procedure to have this file included in the bash-completion package? -- Romain Francoise <rfranco...@debian.org> http://people.debian.org/~rfrancoise/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
