On Mon, Nov 21, 2011 at 06:37:50PM +0100, Daniel Dehennin wrote:
> Guido Günther <a...@sigxcpu.org> writes:
>
> > Hi Daniel,
>
> Hi,
>
> >> + # Permit to change the distribution when ever we want
> >> + if options.distribution:
> >> + gbp.log.debug("Change distribution from {0} to
> >> {1}".format(cp['Distribution'],
> >> +
> >> options.distribution))
> >
> > This doesn't match the string formatting we usually like format % (a,
> > b). Any reason for doing this differently here?
>
> No, I'm just not a python addict and read that format % (a,b) is the old
> way, I'll change it to fit the coding standard of git-dch.
>
> >
> >> + del(cp['Distribution'])
> > Is this necessary?
>
> Yes, just "cp['Distribution'] = options.distribution" provides two
> Distributions lines and the first one (i.e. the old one) is used.
>
> >
> >> + cp['Distribution'] = options.distribution
> >
> >
> >
> >> + else:
> >> + options.distribution = "UNRELEASED"
> > Shouldn't the be handled via the options.distribution default falue?
>
> No, we don't want to mess up with the line 427:
>
> #+begin_src python
> elif cp['Distribution'] != "UNRELEASED" and not found_snapshot_header
> and commits:
> #+end_src
>
> We must not overwrite the 'Distribution' from the changelog file at that
> point, so I do it later.
>
> But as noted in the mail I just sent before reading your answer, I
> introduce a regression and will provide a function to apply all the
> options in one place.
That sound much better. Thanks for working on this!
-- Guido
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
