On Tue, Oct 25, 2011 at 12:46:16AM +0200, Robert Luberda wrote: > Guido Günther writes: > > > > > Signatures start with '-- \n', I've fixed this. > > Why don't you want to use the --no-signature option of format-patch > (and eventually add the '-- \n' line at the end afterwards)? > > As I wrote in my second mail, '-- \n' can also be part of a valid patch. > Imagine the quite unlikely situation that the upstream source contains a > '- \n' line and one wants to remove it. In such a case the unified diff > will contain '-- \n'.
Yes, I was aware of that when comitting the code but it was an improvement at least. I didn't know '--no-signature' exists - it wasn't there when I first wrote the code. This is the most reliable solution and I think we can also safely drop the '-- \n' since it's of no use. I've pushed the code on experimental/. Thanks and sorry for the delay, -- Guido > > > >> (Also note that gpp-pq renames `file.patch' into `file.patch.patch'. > >> I belive it could work smarter, but it's another issue, quite a minor > >> one). > > > > I've fixed this as well on experimental/. > > Thanks a lot. > > Regards, > robert > -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
