+++ Olly Betts [2011-11-25 21:41 +1300]: > On Wed, Nov 09, 2011 at 12:20:40PM +0900, Nobuhiro Iwamatsu wrote: > > I uploaded libpng 1.5 to experimental. > > libpng maintainers plan to transition from libpng 1.2 to 1.5. > > I am checking build it the package depend to libpng. > > > > I noticed your package FTBFS by libpng 1.5. I attached build log. > > Could you check your package ? > > The issue is just that a debian patch hard-codes -lpng12 - in > debian/patches/25debianize-loch-makefile.patch there's: > > -PLIBS = $(shell wx-config --libs --gl-libs) -L$(VTKLIBPATH) $(VTKLIBS) -lGLU > -l > pthread -lz > +PLIBS = $(shell wx-config --libs --gl-libs) $(VTKLIBS) -lGLU -lpthread -lz > -lpn > g12 -ljpeg -lX11 -lGL > > It would probably be better to replace -lpng12 there with: > > `pkg-config --libs libpng`
OK, that's easy and sensible. I've use pkg-config for libgs GL and GLU too as it improves portability/crossability. But what is the correct thing to do in the control file for this transition? set Build-Depends: to libpng15-dev | libpng12-dev libpng12-dev | libpng15-dev libpng-dev libpng-dev | libpng12-dev I assume the last one is best: libpng-dev is presumably generic and will avoid this issue in the future, but is only in experimental currently so we should fallback to the existing libpng12-dev in the meantime. right? Eventually Build-depends could be changed to just 'libpng-dev' (The '| libpng12-dev' will remain useful for backports for a while after the wheezy release). Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
