tags 646740 + patch thanks On 2011-10-26 19:30 +0200, Sven Joachim wrote:
> Source: malaga > Version: 7.12-3.1 > Severity: important > User: [email protected] > Usertags: readline-disabled > > When built in a clean sid chroot without libncurses5-dev installed, > malaga loses readline support. From my pbuilder log: > > ,---- > | checking for readline in -lreadline... no > | checking readline/readline.h usability... yes > | checking readline/readline.h presence... yes > | checking for readline/readline.h... yes > `---- > > Adding libncurses-dev to Build-Depends should avoid this. However, > consider patching the upstream build system which erroneously believes > that curses is necessary for linking with readline. Attached i a debdiff with a patch that works for me. A cleaner solution might be to only patch configure.in, remove configure and other generated files in the clean target and run autoconf at build time (adding the necessary Build-Depends). Cheers, Sven
diff -u malaga-7.12/debian/changelog malaga-7.12/debian/changelog --- malaga-7.12/debian/changelog +++ malaga-7.12/debian/changelog @@ -1,3 +1,10 @@ +malaga (7.12-3.2) unstable; urgency=low + + * Non-maintainer upload. + * Do not unnecessesarily link against ncurses (Closes: #646740). + + -- Sven Joachim <[email protected]> Sat, 03 Dec 2011 12:13:18 +0100 + malaga (7.12-3.1) unstable; urgency=low * Non-maintainer upload. diff -u malaga-7.12/debian/patches/series malaga-7.12/debian/patches/series --- malaga-7.12/debian/patches/series +++ malaga-7.12/debian/patches/series @@ -3,0 +4 @@ +no-ncurses.diff only in patch2: unchanged: --- malaga-7.12.orig/debian/patches/no-ncurses.diff +++ malaga-7.12/debian/patches/no-ncurses.diff @@ -0,0 +1,47 @@ +Author: Sven Joachim <[email protected]> +Bug-Debian: http://bugs.debian.org/646740 +Forwarded: no +Last-Update: 2011-12-03 + +--- + configure | 4 ++-- + configure.in | 4 ++-- + 2 files changed, 4 insertions(+), 4 deletions(-) + +--- a/configure.in ++++ b/configure.in +@@ -39,12 +39,12 @@ + use_readline=$withval, use_readline=yes) + if test $use_readline = yes + then +- AC_CHECK_LIB(readline,readline,,use_readline=no,-lcurses) ++ AC_CHECK_LIB(readline,readline,,use_readline=no) + AC_CHECK_HEADER(readline/readline.h,,use_readline=no) + fi + if test $use_readline = yes + then +- READLINE_LIBS="-lreadline -lcurses" ++ READLINE_LIBS="-lreadline" + READLINE_CFLAGS="-DREADLINE" + else + READLINE_LIBS="" +--- a/configure ++++ b/configure +@@ -18462,7 +18462,7 @@ + echo $ECHO_N "(cached) $ECHO_C" >&6 + else + ac_check_lib_save_LIBS=$LIBS +-LIBS="-lreadline -lcurses $LIBS" ++LIBS="-lreadline $LIBS" + cat >conftest.$ac_ext <<_ACEOF + /* confdefs.h. */ + _ACEOF +@@ -18663,7 +18663,7 @@ + fi + if test $use_readline = yes + then +- READLINE_LIBS="-lreadline -lcurses" ++ READLINE_LIBS="-lreadline" + READLINE_CFLAGS="-DREADLINE" + else + READLINE_LIBS=""
