severity 650932 minor
thanks

Coin,

Sorry for the delay.

Quoting gregor herrmann <gre...@debian.org>:

Any specific reason for checking 2.0.5-1, which only exists in
unstable/hurd-i386?

I wanted to investigate why 2.0.5, which now builds fine on perl 5.14, segfault at apache startup, and 'apt-get source libapache2-mod-perl2' gave me this version. I did not check the version returned; nevertheless the same command on the dev package works well so i retried with -4, giving the same result.

I just tried with 2.0.5-4 (testing/unstable; well, I tried the
version in git), and I don't see any problems.
(Although I see no relevant changes between -1 and -4.)

I did the same on amd64/unstable resulting in... FTBFS (due to tests), seems i'm doomed.


Nevertheless, i just found the problem after diffing 'Apache-Test/Makefile' in both builddirs. I did not bother creating a user and ran the build as root on my test Hurd VM (my bad), which resulted in a different makefile generation.

While the developper's choice to deactivate tests in this case is not a problem, having the clean target depending on the test_clean one, which does not exist, is still a bug. It does not affect Debian in a "normal" situation though. Would you please forward this upstream?

Regards.

--
Marc Dequènes (Duck)
--- Makefile-Apache-Test-hurd-i386	2011-12-07 01:32:55.043684217 +0100
+++ Makefile-Apache-Test-linux-amd64	2011-12-07 01:39:01.384226607 +0100
@@ -35,13 +35,13 @@
 EXE_EXT = 
 FULL_AR = /usr/bin/ar
 LD = cc
-LDDLFLAGS = -shared -L/usr/local/lib -fstack-protector
+LDDLFLAGS = -shared -O2 -g -L/usr/local/lib -fstack-protector
 LDFLAGS =  -fstack-protector -L/usr/local/lib
 LIBC = 
 LIB_EXT = .a
 OBJ_EXT = .o
-OSNAME = gnu
-OSVERS = 0.3
+OSNAME = linux
+OSVERS = 2.6.32-5-amd64
 RANLIB = :
 SITELIBEXP = /usr/local/share/perl/5.14.2
 SITEARCHEXP = /usr/local/lib/perl/5.14.2
@@ -230,10 +230,10 @@
 
 PM_TO_BLIB = lib/Apache/TestRun.pm \
 	../blib/lib/Apache/TestRun.pm \
-	lib/Apache/TestMM.pm \
-	../blib/lib/Apache/TestMM.pm \
 	lib/Apache/TestClient.pm \
 	../blib/lib/Apache/TestClient.pm \
+	lib/Apache/TestMM.pm \
+	../blib/lib/Apache/TestMM.pm \
 	lib/Apache/TestCommonPost.pm \
 	../blib/lib/Apache/TestCommonPost.pm \
 	lib/Apache/TestRunPHP.pm \
@@ -284,10 +284,10 @@
 	../blib/lib/Apache/TestRunParrot.pm \
 	lib/Bundle/ApacheTest.pm \
 	../blib/lib/Bundle/ApacheTest.pm \
-	lib/Apache/TestHarnessPHP.pm \
-	../blib/lib/Apache/TestHarnessPHP.pm \
 	lib/Apache/TestRunPerl.pm \
 	../blib/lib/Apache/TestRunPerl.pm \
+	lib/Apache/TestHarnessPHP.pm \
+	../blib/lib/Apache/TestHarnessPHP.pm \
 	lib/Apache/TestReport.pm \
 	../blib/lib/Apache/TestReport.pm \
 	lib/Apache/TestSSLCA.pm \
@@ -658,14 +658,35 @@
 
 
 # --- MakeMaker test section:
-test::
-	@echo
-	@echo Apache::Test tests cannot be run as the root user.
-	@echo Apache cannot spawn child processes as 'root', therefore
-	@echo the test suite must be run with a non privileged user.
-	@echo Please build Apache::Test as a non-privileged user to
-	@echo run the test suite.
-	@echo
+PASSENV = APACHE_TEST_GROUP=$(APACHE_TEST_GROUP) APACHE_TEST_HTTPD=$(APACHE_TEST_HTTPD) APACHE_TEST_PORT=$(APACHE_TEST_PORT) APACHE_TEST_USER=$(APACHE_TEST_USER) APACHE_TEST_APXS=$(APACHE_TEST_APXS)
+TEST_FILES =
+TEST_VERBOSE = 0
+
+test_clean :
+	$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
+	t/TEST $(APACHE_TEST_EXTRA_ARGS) -clean
+
+run_tests :
+	$(PASSENV) \
+	$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
+	t/TEST $(APACHE_TEST_EXTRA_ARGS) -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES)
+
+test :: pure_all test_clean run_tests
+
+test_config :
+	$(PASSENV) \
+	$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
+	t/TEST $(APACHE_TEST_EXTRA_ARGS) -conf
+
+cmodules: test_config
+	cd c-modules && $(MAKE) all
+
+cmodules_clean: test_config
+	cd c-modules && $(MAKE) clean
+
+testcover :
+	@echo "Cannot run testcover action unless Devel::Cover is installed"
+	@echo "Don't forget to rebuild your Makefile after installing Devel::Cover"
 
 
 # --- MakeMaker ppd section:
@@ -677,7 +698,7 @@
 	$(NOECHO) $(ECHO) '    <IMPLEMENTATION>' >> $(DISTNAME).ppd
 	$(NOECHO) $(ECHO) '        <REQUIRE NAME="Cwd::" VERSION="2.06" />' >> $(DISTNAME).ppd
 	$(NOECHO) $(ECHO) '        <REQUIRE NAME="File::Spec" VERSION="0.8" />' >> $(DISTNAME).ppd
-	$(NOECHO) $(ECHO) '        <ARCHITECTURE NAME="i486-gnu-thread-multi-64int-5.14" />' >> $(DISTNAME).ppd
+	$(NOECHO) $(ECHO) '        <ARCHITECTURE NAME="x86_64-linux-gnu-thread-multi-5.14" />' >> $(DISTNAME).ppd
 	$(NOECHO) $(ECHO) '        <CODEBASE HREF="" />' >> $(DISTNAME).ppd
 	$(NOECHO) $(ECHO) '    </IMPLEMENTATION>' >> $(DISTNAME).ppd
 	$(NOECHO) $(ECHO) '</SOFTPKG>' >> $(DISTNAME).ppd
@@ -688,8 +709,8 @@
 pm_to_blib : $(FIRST_MAKEFILE) $(TO_INST_PM)
 	$(NOECHO) $(ABSPERLRUN) -MExtUtils::Install -e 'pm_to_blib({@ARGV}, '\''$(INST_LIB)/auto'\'', q[$(PM_FILTER)], '\''$(PERM_DIR)'\'')' -- \
 	  lib/Apache/TestRun.pm ../blib/lib/Apache/TestRun.pm \
-	  lib/Apache/TestMM.pm ../blib/lib/Apache/TestMM.pm \
 	  lib/Apache/TestClient.pm ../blib/lib/Apache/TestClient.pm \
+	  lib/Apache/TestMM.pm ../blib/lib/Apache/TestMM.pm \
 	  lib/Apache/TestCommonPost.pm ../blib/lib/Apache/TestCommonPost.pm \
 	  lib/Apache/TestRunPHP.pm ../blib/lib/Apache/TestRunPHP.pm \
 	  lib/Apache/TestConfigParrot.pm ../blib/lib/Apache/TestConfigParrot.pm \
@@ -715,8 +736,8 @@
 	  lib/Apache/TestHandler.pm ../blib/lib/Apache/TestHandler.pm \
 	  lib/Apache/TestRunParrot.pm ../blib/lib/Apache/TestRunParrot.pm \
 	  lib/Bundle/ApacheTest.pm ../blib/lib/Bundle/ApacheTest.pm \
-	  lib/Apache/TestHarnessPHP.pm ../blib/lib/Apache/TestHarnessPHP.pm \
 	  lib/Apache/TestRunPerl.pm ../blib/lib/Apache/TestRunPerl.pm \
+	  lib/Apache/TestHarnessPHP.pm ../blib/lib/Apache/TestHarnessPHP.pm \
 	  lib/Apache/TestReport.pm ../blib/lib/Apache/TestReport.pm \
 	  lib/Apache/TestSSLCA.pm ../blib/lib/Apache/TestSSLCA.pm \
 	  lib/Apache/TestSort.pm ../blib/lib/Apache/TestSort.pm 

Attachment: pgpuubpvKNH4v.pgp
Description: PGP Digital Signature

Reply via email to