Package: triggerhappy
Version: 0.3.4-2
Severity: normal

Dear Maintainer,

Including more than one whitespace character between second and third
field (action) in the config file causes the et->action string to
contain leading whitespaces.
The reason for this is that strtok_r just returns the remaining string
without tokenizing it further (which would return only part of a command
to be run):

triggerparser.c:90
> char *s_action = strtok_r(NULL, "", &sptr);

While leading whitespace is no problem for commands that are executed by
'sh', triggerhappy fails to recognize key remappings as it checks only
the first character (which can be a whitespace char):

trigger.c:204
> } else if (et->action[0] == '<' ) {

An obvious workaround is to include only a single whitespace char
between fields. 
However, it would be great if you could make the parsing more robust.

Cheers,

Raphael

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-rc4+ (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages triggerhappy depends on:
ii  libc6  2.13-21

triggerhappy recommends no packages.

triggerhappy suggests no packages.

-- Configuration Files:
/etc/default/triggerhappy changed [not included]

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to