clone 497469 -1
retitle 497469 git-gui: the UTF-8 characters are shown as garbage
submitter -1 [email protected]
retitle -1 git-gui: preferences window looks like part of parent
quit
Hi,
積丹尼 wrote:
> $ git gui blame some_file
> Click edit->options.
> The "options" window then appears directly on top of the file viewer
> window.
>
> It is shifted vertically, but not horizontally.
> It needs to be shifted horizontally too.
>
> Or else the user will just click edit->options again, getting into
> deep trouble.
Could you explain further? I tried following your recipe, and I didn't
find myself tempted to click Edit → Options again. For comparison,
the preferences dialog for gitk seems to always appear in the top-left
corner of the monitor.
Which is not to say that the current positioning seems particularly
sane. The code does
wm geometry $w "+[winfo rootx .]+[winfo rooty .]"
which based on tcl documentation should put the top-left edge of the
window at an (x, y) position on the _screen_ (whatever that means)
equal to the (x, y) position of the upper-left corner of the current
window in the _root window of the screen_ (again, whatever that
means). In practice, that seems to put it at the left edge of my
monitor, right below the menu bar when my git-gui window is on the
left side of the screen, and in the dead center of the screen when my
git-gui window is on the right. Don't ask me way.
I guess a link to some relevant UI guidelines document might help
decide what the right thing to do is, or if this is just UI design
101, let me know and I'll pass it upstream (that's to Pat Thoyts).
Thanks,
Jonathan
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
