On jeu., 2011-12-22 at 23:06 +0100, Adam Borowski wrote: > On Thu, Dec 22, 2011 at 10:59:23PM +0100, Yves-Alexis Perez wrote: > > On jeu., 2011-12-22 at 22:54 +0100, Adam Borowski wrote: > > > On Thu, Dec 22, 2011 at 10:40:54PM +0100, Yves-Alexis Perez wrote: > > > > On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: > > > > > It'd be great if there was a way to disable this misfeature. > > > > > > > > Try MiscHighlightUrls=False in ~/.config/Terminal/terminalrc > > > > (file:///usr/share/doc/xfce4-terminal/C/advanced.html#hidden-options) > > > > > > Oh, interesting. Its name made me think it's merely about display. > > > > > > However, turning that option off disables not only middle click, but also > > > the right click menu. And that's a bad loss of functionality, since being > > > able to click on URLs is pretty damn useful. > > > > > > It would be good to separate these two. Middle click is something that > > > interferes with paste, right click has a menu where having extra options > > > costs about nothing. > > > > > > > I honestly don't think that's needed, but will report that upstream, > > when back from [VAC] (or if any other team member does it meanwhile). > > Coding wise, it appears to be a trivial change: in > terminal/terminal-widget.c terminal_widget_button_press_event(), on a middle > click, if the hidden setting is false, it would proceed to paste. > > Would a patch of this kind be accepted?
Upstream? No idea. And I wouldn't include it on Debian if it was rejected upstream. I don't question the patch simplicity, but more the option adding. You already have a setting to manage that, adding one more just makes the code less readable. But anyway, that's upstream call :) Regards, -- Yves-Alexis Perez ANSSI/ACE/LAM
signature.asc
Description: This is a digitally signed message part