Source: libsmi
Severity: important
Tags: patch
Please enabled hardened build flags through dpkg-buildflags.
Patch attached. The hardened build flags exposed missing format
strings, for which I also attached a patch.
Cheers,
Moritz
diff -aur libsmi-0.4.8+dfsg2.orig/debian/rules libsmi-0.4.8+dfsg2/debian/rules
--- libsmi-0.4.8+dfsg2.orig/debian/rules 2011-05-18 13:32:01.000000000 +0200
+++ libsmi-0.4.8+dfsg2/debian/rules 2012-01-05 22:53:28.000000000 +0100
@@ -13,7 +13,7 @@
ln -sf /usr/share/misc/config.sub .
ln -sf /usr/share/misc/config.guess .
- ./configure --prefix=/usr --mandir=\$${prefix}/share/man \
+ ./configure $(shell dpkg-buildflags --export=configure) --prefix=/usr --mandir=\$${prefix}/share/man \
--with-mibdir=/usr/share/mibs --sysconfdir=/etc \
--libexecdir=/usr/lib
Nur in libsmi-0.4.8+dfsg2/debian: rules~.
diff -aur libsmi-0.4.8+dfsg2.orig/tools/dump-tree.c libsmi-0.4.8+dfsg2/tools/dump-tree.c
--- libsmi-0.4.8+dfsg2.orig/tools/dump-tree.c 2009-11-15 12:20:25.000000000 +0100
+++ libsmi-0.4.8+dfsg2/tools/dump-tree.c 2012-01-05 22:56:21.000000000 +0100
@@ -117,7 +117,7 @@
smiElement; smiElement = smiGetNextElement(smiElement), i++) {
if (i > 0) fprintf(f, ",");
if (indexname) {
- fprintf(f, indexname);
+ fprintf(f, "%s", indexname);
}
indexname = smiGetElementNode(smiElement)->name;
}
@@ -143,7 +143,7 @@
smiElement = smiGetNextElement(smiElement), i++) {
if (i > 0) fprintf(f, ",");
if (objectname) {
- fprintf(f, objectname);
+ fprintf(f, "%s", objectname);
}
objectname = smiGetElementNode(smiElement)->name;
}
Nur in libsmi-0.4.8+dfsg2/tools: dump-tree.c~.
