On 2012-01-11 14:03, Sitaram Chamarty wrote:
| On Wed, Jan 11, 2012 at 1:59 PM, jaalto <jari.aa...@cante.net> wrote:
| > On 2012-01-11 03:31, Sitaram Chamarty wrote:
| > | > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653968
| > |
| > | Sorry but this does not make any sense to me.
| >
| > The patch adds additional check for two environment variables before
| > the incident. Very simple test to check if Emacs is in use and take
| > actions according to it.
|
| Doesn't make sense to do such extremely specific platform checks
| inside code.
Are you afraid that the "platform checks" will increase? Fear not. I
don't know much other cases where people would run gl-setup. There are
only two places for daily command line:
The terminal and Shell
The Emacs, inside shell buffer
As you know, Emacs is as big as Vi in user base. Your decision will
affect a lot of users.
The current code makes assumptions about environment that are not
necessarily true.
a) The proposed solution is not complex
b) Not hard to maintain
c) The change is easy to understood
d) There solution is not partial (handles the case as expected)
Wouldn't you want to improve the code for everyone's benefit? This all
quite sensible.
Jari
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
