* Eric Sandeen [Tue Jan 03, 2012 at 11:54:46AM -0600]: > On 12/31/11 6:23 AM, Michael Prokop wrote:
[...] > > The responsible change in e2fslibs-dev is this one ("libext2fs: make > > fs->group_desc opaque"): > > > > http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commit;h=efe0b401465a3ee836180614b5b435acbb84fc27 [...] > > The code of extundelete that's failing to compile is: > > > > http://anonscm.debian.org/gitweb/?p=forensics/extundelete.git;a=blob;f=src/extundelete.cc;h=d51d45e15081b01e32e781334ba6d431e7adf88f;hb=HEAD#l944 > //FIXME: may need to change to be compatible with newer file systems > :) Yeah :) > The point of the change was to prevent this kind of use of ->group_desc: > group_descriptor_table[n] = fs->group_desc[n]; > because the size of group_desc may change. Instead, we need something like: > group_descriptor_table[n] = *ext2fs_group_desc(fs, fs->group_desc, n); > I think my pointer-fu is ok ;) Maybe a memcpy would be clearer. Seems to work - thanks a lot for your help, Eric! > There are other problems though, I think, in parse_inode_block() for example, > things in there have changed as well... this tool seems to be getting a little > to grubby in the ext internals. I think maybe it should be making > use of ext2fs_swap_inode() instead. Ok. regards, -mika-
signature.asc
Description: Digital signature