On 01/15/2012 11:56 PM, Antoine Beaupré wrote:
> On Sun, 15 Jan 2012 17:12:04 +0100, Julian Taylor
> <jtaylor.deb...@googlemail.com> wrote:
>> On 01/15/2012 05:03 PM, Antoine Beaupré wrote:
>>> On Sat, 07 Jan 2012 21:39:56 +0100, Julian Taylor
>>> <jtaylor.deb...@googlemail.com> wrote:
>>>> bantool: ${BANTOOL_OBJECTS}
>>>> - ${CC} ${CFLAGS} ${LDFLAGS} -o $@ ${BANTOOL_OBJECTS} ${IRCDLIBS}
>>>> + ${CC} ${CFLAGS} ${LDFLAGS} -o $@ ${BANTOOL_OBJECTS} ${IRCDLIBS} ${LIBS}
>>>
>>> I am not sure how this fixes the problem: isn't the -lsqlite3 flag still
>>> in ${IRCDLIBS}?
>>>
>>> If this patch was tested and works, I'll gladly commit it. :)
>>>
>>> A.
>>>
>>
>> the issue is that lsqlite3 was in LDFLAGS before which is placed before
>> the objects
>> I moved it to LIBS the variable where libraries are usually placed.
>>
>> true, it is now in IRCDLIBS and LIBS, so you can remove the additional
>> LIBS there.
>> (though specifying a library multiple times does no harm.)
>>
>> The patch was build-tested in ubuntu and debian, but I did no runtime tests.
>
> I guess what gets me confused is that you didn't actually *move* the
> -lsqlite3 call, from what I can tell, you just added it to the end.no compare this hunk with the existing patch, I moved lsqlite from LDFLAGS to LIBS: @@ -14,6 +14,7 @@ LEXLIB = @LEXLIB@ CFLAGS = @IRC_CFLAGS@ -DIRCD_PREFIX=\"@prefix@\" LDFLAGS = @LDFLAGS@ +LIBS = @LIBS@ -lsqlite3 MKDEP = @MKDEP@ -DIRCD_PREFIX=\"@prefix@\" MV = @MV@ RM = @RM@ > > If it works, that's fine I guess, but it feels wrong. > you can test it yourself by adding -Wl,--as-needed to LDFLAGS
signature.asc
Description: OpenPGP digital signature
