On Tue, February 7, 2012 00:15, Filipus Klutiero wrote: > On 2012-02-06 03:57, Thijs Kinkhorst wrote: >> On Thu, February 2, 2012 19:18, Filipus Klutiero wrote: >>> Package: phpmyadmin >>> Version: 4:3.4.9-1 >>> Severity: wishlist >>> >>> It is currently painful to show all records in a table. One needs to >>> look at the number of rows, enter that number in the field which asks >>> the number of rows to show, then reset the starting row to 0 and press >>> enter. >>> >>> There is actually a "Show all" button to do just that, the problem is >>> that the button does not show by default. A configuration option needs >>> to be enabled: >>> $cfg['ShowAll'] boolean >>> Defines whether a user should be displayed a "show all (rows)" button >>> in >>> browse mode or not. >>> http://www.phpmyadmin.net/documentation/ >>> >>> This option is disabled by default. >>> >>> >>> This was requested upstream, but Marc Delisle rejected, asking to be >>> trusted: >>> https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3476721&group_id=23067 >> It's better to be safe than sorry. Showing all rows on any table of >> serious size can have grave consequences on MySQL server, web server >> (and >> the client). Having a button by default means you can easily cause >> trouble >> on your database server just by misclicking. > > That depends on what the button does. If it instantly queries, then it's > as you say. However, if there is a validation on the button, like a > JavaScript popup as described in > http://sourceforge.net/tracker/?func=detail&atid=377411&aid=3476721&group_id=23067 > , then such a mistake can be made as hard to make as we deem necessary. >> Of course there are many >> tables where showing all rows is safe and as you say there are options >> to >> do that already (enter any sufficiëntly high number in the 'rows to >> show' >> box as you say, or executing SELECT * FROM table). And you can also >> enable >> the setting. >> >> I think it's a sane default as it is. Michal, only thing: could you >> perhaps extend the description of that boolean option a bit to explain >> the >> why and the consequences? > > That would be a nice start. It may not be useful in the end if the > option is eliminated (if the Show all button is perfected enough, I do > not see why keeping an option to disable it would be necessary). But > meanwhile, it would clarify what's needed to get there. > > Note that this report is not saying the current default for the option > is insane. It may well be the best default given the way Show all works > currently. All I'm asking is get the Show all button to display by > default (which does not exclude displaying it unconditionally). The > button may require improvement for such a change to be reasonable to make.
I'll leave this for Michal and/or upstream to decide. Thijs -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
