Package: ttf-atarismall Version: 2.1-4 Severity: wishlist Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces unreliability into upgrades; it means that the conffile is removed or not depending on whether dpkg happens to be unpacked before ttf-atarismall. This seems generally undesirable; it would be better to enforce a single code path. (This is academic for Debian because the version of dpkg in squeeze supported dpkg-maintscript-helper, hence Severity: wishlist; Ubuntu's last LTS release didn't have a sufficient version of dpkg for that which is why I care.) It would be nice to just use dh_installdeb's support for generating dpkg-maintscript-helper commands, which was introduced in debhelper 8.1.0. This would remove duplicate code from your maintainer scripts - in fact, you'd no longer need to have handwritten maintainer scripts at all. Here's a patch: * Use maintscript support in dh_installdeb rather than writing out dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a new enough version of dpkg rather than using 'dpkg-maintscript-helper supports' guards, leading to more predictable behaviour on upgrades. diff -Nru ttf-atarismall-2.1/debian/control ttf-atarismall-2.1/debian/control --- ttf-atarismall-2.1/debian/control 2011-07-20 11:25:30.000000000 +0100 +++ ttf-atarismall-2.1/debian/control 2012-02-12 16:48:22.000000000 +0000 @@ -3,12 +3,13 @@ Priority: optional Maintainer: Gürkan Sengün <gur...@phys.ethz.ch> Uploaders: Debian Fonts Task Force <pkg-fonts-de...@lists.alioth.debian.org> -Build-Depends: debhelper (>= 7.0.50~), fontforge +Build-Depends: debhelper (>= 8.1.0~), fontforge Homepage: http://gnu.ethz.ch/linuks.mine.nu/atari/ Standards-Version: 3.9.2 Package: ttf-atarismall Architecture: all +Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends} Description: Very small 4 x 8 font This is named atari small because it was designed for a terminal emulator diff -Nru ttf-atarismall-2.1/debian/maintscript ttf-atarismall-2.1/debian/maintscript --- ttf-atarismall-2.1/debian/maintscript 1970-01-01 01:00:00.000000000 +0100 +++ ttf-atarismall-2.1/debian/maintscript 2012-02-12 16:47:29.000000000 +0000 @@ -0,0 +1 @@ +rm_conffile /etc/defoma/hints/ttf-atarismall.hints 2.1-4 diff -Nru ttf-atarismall-2.1/debian/postinst ttf-atarismall-2.1/debian/postinst --- ttf-atarismall-2.1/debian/postinst 2011-07-20 10:09:20.000000000 +0100 +++ ttf-atarismall-2.1/debian/postinst 1970-01-01 01:00:00.000000000 +0100 @@ -1,9 +0,0 @@ -#!/bin/sh -set -e - -if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then - dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-atarismall.hints 2.1-4 -- "$@" -fi - -#DEBHELPER# - diff -Nru ttf-atarismall-2.1/debian/postrm ttf-atarismall-2.1/debian/postrm --- ttf-atarismall-2.1/debian/postrm 2011-07-20 10:09:43.000000000 +0100 +++ ttf-atarismall-2.1/debian/postrm 1970-01-01 01:00:00.000000000 +0100 @@ -1,9 +0,0 @@ -#!/bin/sh -set -e - -if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then - dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-atarismall.hints 2.1-4 -- "$@" -fi - -#DEBHELPER# - diff -Nru ttf-atarismall-2.1/debian/preinst ttf-atarismall-2.1/debian/preinst --- ttf-atarismall-2.1/debian/preinst 2011-07-20 10:09:36.000000000 +0100 +++ ttf-atarismall-2.1/debian/preinst 1970-01-01 01:00:00.000000000 +0100 @@ -1,9 +0,0 @@ -#!/bin/sh -set -e - -if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then - dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-atarismall.hints 2.1-4 -- "$@" -fi - -#DEBHELPER# - Thanks, -- Colin Watson [cjwat...@ubuntu.com] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org