tags 659745 patch thanks * Mark Caglienzi [120213 15:44 +0100]:
> Package: moc > Version: 1:2.5.0~alpha4+svn20111012-1 > Severity: normal > > Hello, > when I enter a directory containing a lyrics file (that must have the same > name of the song, but without extension) ending with a dot, mocp crashes > with the following message: > > mocp: decoder.c:128: find_extn_decoder: Assertion `extn && extn[0]' failed. > Aborted > > For example, if the song filename is "f.o.o..mp3" and the lyrics filename > is "f.o.o." mocp crashes. Obviously, if I name the lyrics file "f.o.o" moc > doesn't crash, but doesn't recognize the lyrics. I got a patch from John Fitgerald, upstream, which solves that behaviour. I'll upload the new version in a few days together with some other fixes. Elimar -- Obviously the human brain works like a computer. Since there are no stupid computers humans can't be stupid. There are just a few running with Windows or even CE ;-)
From: John Fitzgerald Debian-Bug: #659745 Index: decoder.c =================================================================== --- decoder.c (revision 2382) +++ decoder.c (working copy) @@ -175,7 +175,7 @@ static int find_decoder (const char *extn, const char *file, char **mime) result = -1; if (mime && *mime) result = find_mime_decoder (default_decoder_list, plugins_num, *mime); - if (result == -1 && extn) + if (result == -1 && extn && *extn) result = find_extn_decoder (default_decoder_list, plugins_num, extn); return result;
