I hate to bikeshed, but I must jump in here. The support_cppflags patch changes how CMake works WRT its documentation, its behaviour on other platforms and even behaviour on other Linux distributions.
Changing how CMake works in this way without upstream's agreement to
follow suit will only cause confusion for end-users, who will not expect
this undocumented divergence in CMake's behaviour.
I understand that you want to make the job of packagers easier, but IMHO
it's their job to understand how their build system works, including how
to correctly pass various common build flags into the build system. Some
less intrusive ways to make this easier for them might be:
* Improve CMake's documentation
* Providing a quick "cheat sheet for Debian package maintainers"
in a README.Debian file
* Patch CMake to output a warning message when CPPFLAGS is set in
the environment
Hence please consider reverting this patch, and working with upstream to
find a solution that works for them as well as us. :)
Regards,
--
Sam Morris <https://robots.org.uk/>
3412 EA18 1277 354B 991B C869 B219 7FDB 5EA0 1078
signature.asc
Description: This is a digitally signed message part
