Package: procps
Version: 1:3.2.5-1
Severity: wishlist

Hello,

this is a follow-up to #277111. Unfortunately this bug is already
archived so I cannot reopen it.

I personally think it's really helpful to see which kernel parameters
are changed during boot. Therefor, please use -q only if $VERBOSE=no.

My mail to martin f krafft and his reply are attached, including my
suggested patch.


Thanks for your work & regards
   Mario
-- 
I heard, if you play a NT-CD backwards, you get satanic messages...
That's nothing. If you play it forwards, it installs NT.
--- Begin Message ---
On Mon, Oct 18, 2004 at 06:40:25PM +0200, martin f krafft wrote:
> When procps loads /etc/sysctl.conf during the boot, it writes all
> settings to stdout. It should not do that. Please add -q even in
> $VERBOSE mode!

Hmmm, why should it be quiet even in $VERBOSE mode?
I personally think it's really helpful sometimes to see which kernel
parameters are changed during boot. Especially now when netbase (4.22)
deprecates /etc/network/options and refers to /etc/sysctl.conf instead
(see /usr/share/doc/netbase/README.Debian) and thus /etc/sysctl.conf
becomes more important now than before.
And I don't see any reason not to print them if $VERBOSE = yes.

I'll reopen the bug if you agree with me.

I did talk to Elrond and it seems that sysctl in 2.0.7 had no -q, which
was most likely the reason for -n + >/dev/null.
Now, there is -q, so the correct patch should be to simply replace -n
with -q if $VERBOSE = no. There should be no need for >/dev/null anymore
(patch attached).


regards
   Mario
-- 
[mod_nessus for iauth]
<delta> "scanning your system...found depreciated OS...found
        hole...installing new OS...please reboot and reconnect now"
--- /etc/init.d/procps.sh       2004-11-17 03:18:32.000000000 +0100
+++ procps.sh   2005-09-27 19:34:03.000000000 +0200
@@ -19,14 +19,12 @@
                fi
                if [ "$VERBOSE" = "no" ]
                then
-                       n="-n"
-                       redir=">/dev/null"
+                       quiet="-q"
                else
                        echo "Setting kernel variables ..."
-                       n=""
-                       redir=""
+                       quiet=""
                fi
-               eval "/sbin/sysctl $n -q -p $redir"
+               /sbin/sysctl $quiet -p
                if [ "$VERBOSE" = "yes" ]
                then
                        echo "... done."

--- End Message ---
--- Begin Message ---
also sprach Mario 'BitKoenig' Holbe <[EMAIL PROTECTED]> [2005.09.27.1948 +0200]:
> I'll reopen the bug if you agree with me.

I suppose I do agree...

-- 
 .''`.     martin f. krafft <[EMAIL PROTECTED]>
: :'  :    proud Debian developer and author: http://debiansystem.info
`. `'`
  `-  Debian - when you have better things to do than fixing a system
 
Invalid/expired PGP (sub)keys? Use subkeys.pgp.net as keyserver!
 
"although occasionally there is
 something to be said for solitude."
                                          -- special agent dale cooper

Attachment: signature.asc
Description: Digital signature (GPG/PGP)


--- End Message ---

Reply via email to