Hi,

Wookey wrote:

> Cyclic build-dependencies are a big problem in Debian, which make new
> ports very difficult, or rebuilds for other reasons such as hardware
> optimisations.

Thanks very much for working on this.

I'll let others talk about any thorny design issues. :)  I just have
a couple of quick hints:

> --- dpkg-1.16.0.3.orig/scripts/Dpkg/Control/Fields.pm 2011-05-04 
> 09:28:00.000000000 +0100
> +++ dpkg-1.16.0.3/scripts/Dpkg/Control/Fields.pm      2011-07-07 
> 14:53:40.510189000 +0100
> @@ -73,10 +73,20 @@
>          dependency => 'normal',
>          dep_order => 1,
>      },
> +    'Build-Depends-Stage1' => {
> +        allowed => ALL_SRC,
> +        dependency => 'normal',
> +        dep_order => 1,

The dep_order values are all supposed to be distinct.  I am not
sure how important the particular order is --- Raphaƫl, what
would go wrong if we just used alphabetical order to avoid this
particular maintenance hassle?

[...]
> +++ dpkg-1.16.0.3/scripts/dpkg-buildpackage.pl        2011-07-06 
> 02:23:11.439824001 +0100
> @@ -122,6 +122,7 @@
[...]
> +my $buildstage = 0;

Where does this get set to nonzero?

[...]
> --- dpkg-1.16.0.3.orig/scripts/dpkg-checkbuilddeps.pl 2011-05-04 
> 09:28:01.000000000 +0100
> +++ dpkg-1.16.0.3/scripts/dpkg-checkbuilddeps.pl      2011-07-06 
> 02:46:05.039824002 +0100
> @@ -49,6 +49,8 @@
>                   retrieving them from control file
>    --admindir=<directory>
>                   change the administrative directory.
> +  --stage=<level>
> +                 use build-depends-stage level specified

Would be nice to document this in the manpage, too.  See
http://bugs.debian.org/629480#35 for an example patch adding a
Build-Depends variant that covers its bases well.

A couple example tests, either in the form of simple commands I
can try that use equivs, or, even better, a patch against

  git://git.debian.org/dpkg/pkg-tests.git

would be nice for ironing out the behavior (and acting as a surrogate
user that will notice and complain if it gets broken in the future).

I wonder if in some cases the stage1 package is already useful and
deserves its own name, but please don't take such musings seriously
until I have stared at a demo and had a chance to work out the pieces
I am missing.

Sincerely,
Jonathan



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to