Hi! Thanks for the patches, I am preparing to upload a new upstream release so no NMU required :)
I broke the Makefile patch in last upload so the hardening flags weren't actually applied and lead to FTBFS on armhf. > As I see it there are two problems in the package: > > 1. Hardening rules are not properly passed to the build system, for that you > might need to set CFLAGS and LDFLAGS as: > make -C src CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" OS=Linux > CPU=$(DEB_HOST_ARCH_CPU) picolisp tools gate > make -C src64 CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" OS=Linux > > This way the build system takes the flags, but FTBFS, with full hardening > set. The flags are passed to the build system properly, but the Makefile mistakenly overrides the CFLAGS. > 2. amd64 and armhf arches fail because the linkage is trying to link non-PIE > object code. On amd64 -fPIE is explicitly disabled because it's mostly written in assembly and already handles PIC when needed. The codes aren't compiled with gcc so enable -fPIE is meaningless. > The following patch should fix the issue with -fPIE, but you are still not > passing hardening flags to the build. > I have not been able to test on armhf, but once I do, and if you dont have > inconvenient I shall proceed with a NMU. Thanks again, but once picolisp_build_on_multi_cpu.patch is fixed they will build fine. Cheers, Kanru
pgpDD6dVjCjc1.pgp
Description: PGP signature
