On Thu, 2005-09-29 at 14:55 +0200, Marek Habersack wrote:
> On Thu, Sep 29, 2005 at 10:49:47PM +1000, Andrew Bartlett scribbled:
> [snip]
> > > > and add it to the already too many patches in Samba for debian.  Then
> > > > work with jra and jerry on making this upstream, if it can be done
> > > > portably.  I can't imagine building the other utilities will be a big
> > > > pain.  The tricky bit might be deciding to use the separate makefile or
> > > > the main build system.
> > > I think the best idea would be to just create a Makefile.libtdb by hand 
> > > and
> > > slam it in the source/tdb/ directory
> > 
> > This is exactly what already exists, I'm suggesting just patching the
> > extra in.
> You missed my point :) - I suggest adding another Makefile in the
> source/tdb/ dir and not touching the original one - that way, the changes
> stay clear of the upstream samba code == less ado with maintaining that
> patch should the original Makefile change. After all, it's a Debian-specific
> thing we're talking about :) (especially that, as we say below, the core
> samba should not link against the shared tdb library - the more reason not
> to touch the upstream source/tdb/ Makefile IMO)

The core Samba doesn't use the source/tdb Makefile.  Samba compiles tdb
for it's purposes from the main source/Makefile.  Adding the extra
targets for libtdb to the end of that file should not be too painful...

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to