Your message dated Mon, 21 Feb 2005 16:47:39 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#296280: fixed in webcalendar 0.9.45-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Feb 2005 14:05:07 +0000
>From [EMAIL PROTECTED] Mon Feb 21 06:05:07 2005
Return-path: <[EMAIL PROTECTED]>
Received: from grace.wrladv.com [24.140.1.164] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1D3EBO-00078i-00; Mon, 21 Feb 2005 06:05:06 -0800
Received: from minbar.local.wrladv.com [69.208.22.238] by grace.wrladv.com with 
ESMTP
  (SMTPD32-8.05) id AA8038CF0094; Mon, 21 Feb 2005 09:04:48 -0500
Received: from rfunk by minbar.local.wrladv.com with local (Exim 4.34)
        id 1D3EBI-0002jf-Kz; Mon, 21 Feb 2005 09:05:00 -0500
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Rob Funk <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: Remote SQL injection in login/validate
X-Mailer: reportbug 3.2
Date: Mon, 21 Feb 2005 09:05:00 -0500
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
        HTML_MESSAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: webcalendar
Version: 0.9.45-2
Severity: grave
Tags: security patch
Justification: user security hole


Upstream reports a security hole:
http://sourceforge.net/tracker/index.php?func=detail&aid=1121329&group_id=3870&atid=303870
| There is a security hole in WebCalendar 0.9.45 and
| earlier that can allow a malicious user to issue SQL
| commands to affect your database. The user could
| insert data, delete data or drop tables. The malicious
| user does not need to have a valid WebCalendar login.
| 
| This security issue does not affect sites using
| http-based authentication for WebCalendar or sites
| running in single-user mode. It only affects installs
| using web-based authentication and running in
| multi-user mode.

Patch from upstream:
*** includes/validate.php.orig  Fri Nov  5 21:43:38 2004
--- includes/validate.php       Sat Feb 12 08:32:45 2005
***************
*** 38,43 ****
--- 38,55 ----
            $login_pw = split('\|', decode_string ($encoded_login));
            $login = $login_pw[0];
            $cryptpw = $login_pw[1];
+           // Security fix.  Don't allow certain types of characters in
+           // the login.  WebCalendar does not escape the login name in
+           // SQL requests.  So, if the user were able to set the login
+           // name to be "x';drop table u;",
+           // they may be able to affect the database.
+           if ( ! empty ( $login ) ) {
+             if ( $login != addslashes ( $login ) ) {
+               echo "Illegal characters in login " .
+                 "<tt>" . htmlentities ( $login ) . "</tt>";
+               exit;
+             }
+           }
            // make sure we are connected to the database for password check
            $c = dbi_connect ( $db_host, $db_login, $db_password, $db_database 
);
            if ( ! $c ) {
*** login.php.orig      Tue Nov 23 02:55:16 2004
--- login.php   Sat Feb 12 08:21:09 2005
***************
*** 62,67 ****
--- 62,71 ----
        $login = stripslashes ( $login );
      }
      $login = trim ( $login );
+     if ( $login != addslashes ( $login ) ) {
+       echo "Illegal characters in login";
+       exit;
+     }
      if ( user_valid_login ( $login, $password ) ) {
        user_load_variables ( $login, "" );
        // set login to expire in 365 days


-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-686-smp
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages webcalendar depends on:
ii  apache [httpd]                1.3.33-3   versatile, high-performance HTTP s
ii  debconf [debconf-2.0]         1.4.30.11  Debian configuration management sy
ii  mysql-server                  4.0.23-3   mysql database server binaries
ii  php4                          4:4.3.10-2 server-side, HTML-embedded scripti
ii  php4-cli                      4:4.3.10-2 command-line interpreter for the p
ii  php4-mysql                    4:4.3.10-2 MySQL module for php4

-- debconf information:
* webcalendar/conf/db_host: localhost
* webcalendar/note/sql_install:
  webcalendar/status/db_installed: false
* webcalendar/note/admin_user:
* webcalendar/conf/db_persistent: true
  webcalendar/conf/single_user_login:
* webcalendar/conf/single_user_mode: false
* webcalendar/conf/db_database: webcalendar
* webcalendar/conf/db_type: mysql
* webcalendar/conf/db_login: webcalendar
* webcalendar/conf/db_password: Zeeph9po
* webcalendar/conf/use_http_auth: false
* webcalendar/status/debconf_managed: true

---------------------------------------
Received: (at 296280-close) by bugs.debian.org; 21 Feb 2005 21:53:02 +0000
>From [EMAIL PROTECTED] Mon Feb 21 13:53:02 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1D3LUE-0005Ht-00; Mon, 21 Feb 2005 13:53:02 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
        id 1D3LP1-0005CH-00; Mon, 21 Feb 2005 16:47:39 -0500
From: Tim Peeler <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#296280: fixed in webcalendar 0.9.45-3
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Mon, 21 Feb 2005 16:47:39 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 
X-CrossAssassin-Score: 3

Source: webcalendar
Source-Version: 0.9.45-3

We believe that the bug you reported is fixed in the latest version of
webcalendar, which is due to be installed in the Debian FTP archive:

webcalendar_0.9.45-3.diff.gz
  to pool/main/w/webcalendar/webcalendar_0.9.45-3.diff.gz
webcalendar_0.9.45-3.dsc
  to pool/main/w/webcalendar/webcalendar_0.9.45-3.dsc
webcalendar_0.9.45-3_all.deb
  to pool/main/w/webcalendar/webcalendar_0.9.45-3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tim Peeler <[EMAIL PROTECTED]> (supplier of updated webcalendar package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 21 Feb 2005 16:31:17 -0500
Source: webcalendar
Binary: webcalendar
Architecture: source all
Version: 0.9.45-3
Distribution: unstable
Urgency: low
Maintainer: Tim Peeler <[EMAIL PROTECTED]>
Changed-By: Tim Peeler <[EMAIL PROTECTED]>
Description: 
 webcalendar - PHP-Based multi-user calendar
Closes: 291590 295960 296280
Changes: 
 webcalendar (0.9.45-3) unstable; urgency=low
 .
   * removed mysql-server or postgres requirements (closes: #291590)
   * added patch to fix sql injection bug CAN-2005-0474 (closes: #295960, 
#296280)
Files: 
 f4b6881c1afe86b686fe27c2b617aef4 595 web optional webcalendar_0.9.45-3.dsc
 f5049a07e2fd24e91795de74518aec74 8388 web optional webcalendar_0.9.45-3.diff.gz
 c21c6f6c7e0617bdf592db4585073a40 627652 web optional 
webcalendar_0.9.45-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCGlM3SYIMHOpZA44RAiRVAKCT/NTA3MUjtUcrUGzCPqhGVRGZoACbBgVK
2PqTBz/mVM2bB2TZAI6T+nk=
=vSbn
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to