Your message dated Sat, 27 Oct 2007 23:47:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#439362: fixed in lastfmsubmitd 0.36-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: lastfmsubmitd
Version: 0.35-3
Severity: grave
Tags: patch

Hello... again. O:-)

The sync() method of Spool does not honour the configured spool_path.
This causes data loss when the daemon exits but there are pending
submissions on the queue. Please find a (tested) trivial patch below,
though I'd recommend doing something involving a try block, possibly
calling lastfm.submit() *before* calling unlink().

Cheers,

--- lastfmsubmitd~
+++ lastfmsubmitd
@@ -111,7 +111,7 @@
         for f in self.files:
             os.unlink(f)
         if self.subs:
-            newfile = lastfm.submit(self.subs)
+            newfile = lastfm.submit(self.subs, self.spool_path)
             self.files = [newfile]
         else:
             self.files = []

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
If there is a sin against life, it consists perhaps not so much in
despairing of life as in hoping for another life and in eluding the
implacable grandeur of this life.
                -- Albert Camus



--- End Message ---
--- Begin Message ---
Source: lastfmsubmitd
Source-Version: 0.36-1

We believe that the bug you reported is fixed in the latest version of
lastfmsubmitd, which is due to be installed in the Debian FTP archive:

lastfmsubmitd_0.36-1.diff.gz
  to pool/main/l/lastfmsubmitd/lastfmsubmitd_0.36-1.diff.gz
lastfmsubmitd_0.36-1.dsc
  to pool/main/l/lastfmsubmitd/lastfmsubmitd_0.36-1.dsc
lastfmsubmitd_0.36-1_all.deb
  to pool/main/l/lastfmsubmitd/lastfmsubmitd_0.36-1_all.deb
lastfmsubmitd_0.36.orig.tar.gz
  to pool/main/l/lastfmsubmitd/lastfmsubmitd_0.36.orig.tar.gz
lastmp_0.36-1_all.deb
  to pool/main/l/lastfmsubmitd/lastmp_0.36-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Decklin Foster <[EMAIL PROTECTED]> (supplier of updated lastfmsubmitd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 27 Oct 2007 19:17:42 -0400
Source: lastfmsubmitd
Binary: lastfmsubmitd lastmp
Architecture: source all
Version: 0.36-1
Distribution: unstable
Urgency: low
Maintainer: Decklin Foster <[EMAIL PROTECTED]>
Changed-By: Decklin Foster <[EMAIL PROTECTED]>
Description: 
 lastfmsubmitd - submission daemon for the Last.fm social music network
 lastmp     - MPD client for lastfmsubmitd
Closes: 439362
Changes: 
 lastfmsubmitd (0.36-1) unstable; urgency=low
 .
   * New upstream release
     - Plugin interface has been rewritten. This *will* break your existing
       code, and should be considered unstable until the next version or two.
       Running with a different spool directory should now not cause any
       problems. (Closes: #439362)
     - Thanks to dato for the suggestions, and testing-watch for shaming me
       into packaging up the fix.
Files: 
 9e0ba32bc24c947e7aa827499a1e3d67 666 sound optional lastfmsubmitd_0.36-1.dsc
 404c5da0f6235abf29c178422936ff2c 23145 sound optional 
lastfmsubmitd_0.36.orig.tar.gz
 4600d9ed9f22dc769fd93d5255c51764 10670 sound optional 
lastfmsubmitd_0.36-1.diff.gz
 b3e2914b4ed9868d47285a8292b5686d 29618 sound optional 
lastfmsubmitd_0.36-1_all.deb
 a0959682caca1b6d240bf78f02073547 14732 sound optional lastmp_0.36-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHI8uYuIJGh/GWjRsRAj+yAJ9mQCxixJ4aOCBnpuDMmujX4o7+uwCdHZxP
K1/R8nNDud0ogDULA1AEzHs=
=NC57
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to