package abraca
tags 439567 + patch
thanks

(I'm a NM trying to do RC bug squashing. Cc'ing my AM, Michael Koch)

This bug is easily reproducible as follows:

apt-get source abraca
cd abraca-0.2
dpkg-buildpackage -us -uc  # works
dpkg-buildpackage -us -uc  # works - i.e. repeated builds aren't the problem
HOME=/x dpkg-buildpackage -us -uc    # doesn't work

The attached patch makes it build successfully; the debdiff relative to
the version in the archive only contains some increased library
dependencies, and some dropped dependencies on indirectly-depended
libraries. It's probably not worth making this NMU without fixing the issues
below, though.

I was able to make my NMU-candidate version of abraca add files to
xmms2d, but I was unable to get any files to appear in the abraca
playlist, and I was unable to get it to actually play music (xmms2d
segfaulted when I tried). However, these aren't regressions, since
the version in the archive behaves the same for me; I wonder which
package is at fault.

abraca should probably have a Recommends: xmms2 so users get the metapackage
containing the daemon and some plugins; according to
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=440678 it
can connect to remote xmms2 daemons, but it's not at all obvious how.

Michael: how would you recommend proceeding with this? Should I bother
asking for a sponsored-NMU of a known-broken package in the hope that it's
xmms2's fault, should I add the Recommends, should I file a separate bug for
the Recommends?

    Simon
diff -u abraca-0.2/debian/changelog abraca-0.2/debian/changelog
--- abraca-0.2/debian/changelog
+++ abraca-0.2/debian/changelog
@@ -1,3 +1,11 @@
+abraca (0.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Use a temporary $HOME during build to stop waf writing outside the build
+    directory (Closes: #439567).
+
+ -- Simon McVittie <[EMAIL PROTECTED]>  Mon, 10 Dec 2007 19:47:31 +0000
+
 abraca (0.2-1) unstable; urgency=low
 
   * Initial release (Closes: #430729)
diff -u abraca-0.2/debian/rules abraca-0.2/debian/rules
--- abraca-0.2/debian/rules
+++ abraca-0.2/debian/rules
@@ -9,18 +9,19 @@
 endif
 
 export NOCOLOR=1
+WAF_HOME = debian/tmp-waf-home
 
 configure: configure-stamp
 configure-stamp:
 	dh_testdir
-	./waf configure --prefix=/usr
+	HOME=$(WAF_HOME) ./waf configure --prefix=/usr
 	touch configure-stamp
 
 build: build-stamp
 
 build-stamp: configure-stamp
 	dh_testdir
-	./waf -v
+	HOME=$(WAF_HOME) ./waf -v
 	xsltproc --nonet /usr/share/sgml/docbook/stylesheet/xsl/nwalsh/manpages/docbook.xsl debian/abraca.xml
 	touch $@
 
@@ -29,7 +30,8 @@
 	dh_testroot
 	rm -f build-stamp configure-stamp
 	rm -f abraca.1
-	./waf distclean
+	HOME=$(WAF_HOME) ./waf distclean
+	rm -rf debian/tmp-waf-home
 	dh_clean
 
 install: build
@@ -37,7 +39,7 @@
 	dh_testroot
 	dh_clean -k
 	dh_installdirs
-	./waf install --destdir=$(CURDIR)/debian/abraca install
+	HOME=$(WAF_HOME) ./waf install --destdir=$(CURDIR)/debian/abraca install
 	dh_install debian/abraca.desktop usr/share/applications
 
 # Build architecture-independent files here.

Attachment: signature.asc
Description: Digital signature

Reply via email to