Your message dated Sat, 08 Mar 2008 08:47:06 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#469146: fixed in open-vm-tools 2008.02.13-77928-2
has caused the Debian Bug report #469146,
regarding binary name errors in init script and vmxnet detection
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
469146: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=469146
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: open-vm-tools
Version: 2008.02.13-77928-1
Severity: serious
Cause: renders package unusable
Tags: patch

On /etc/init.d/open-vm-tools script, the program names of vmware-checkvm and 
vmware-guestd are wrong.
Instead of 'vmware-checkvm' there is 'checkvm' (and the path is wrong), and 
instead of 'vmware-guestd' there is 'guestd'.
The init script present in the package always tells that it is not running on 
a vm, as checkvm binary is not found.

In addition, the vmxnet detection code doesn't work, as the function always 
returns 1.

I've attached the patch that fixes the script for both problems.

Bye,
Emilio Scalise
--- open-vm-tools.old	2008-02-24 20:27:52.000000000 +0100
+++ open-vm-tools	2008-03-03 13:30:30.000000000 +0100
@@ -12,18 +12,22 @@
 
 . /lib/lsb/init-functions
 
+CHECKVMBIN="vmware-checkvm"
+CHECKVMPATH="/usr/sbin/"
+GUESTD="vmware-guestd"
+
 vmxnet_needed ()
 {
-	HWVERSION="$(checkvm -h | head -1 | cut -f5 -d\ )"
+	HWVERSION="$($CHECKVMBIN -h | head -1 | cut -f5 -d\ )"
 
 	for DEVICE in /sys/bus/pci/devices/*
 	do
-		if grep -q 15ad ${DEVICE} && grep -q 0720 ${DEVICE}
+		if grep -q 15ad ${DEVICE}/vendor && grep -q 0720 ${DEVICE}/device
 		then
 			return 0
 		fi
 
-		if [ "${HWVERSION}" -ge "4" ] && grep -q 1022 ${DEVICE} && grep -q 2000 ${DEVICE}
+		if [ "${HWVERSION}" -ge "4" ] && grep -q 1022 ${DEVICE}/vendor && grep -q 2000 ${DEVICE}/device
 		then
 			return 0
 		fi
@@ -33,7 +37,7 @@
 }
 
 exit_if_not_in_vm () {
-	if [ ! -x /usr/bin/checkvm ] || ! /usr/bin/checkvm > /dev/null 2>&1
+	if [ ! -x $CHECKVMPATH$CHECKVMBIN ] || ! $CHECKVMPATH$CHECKVMBIN > /dev/null 2>&1
 	then
 		echo "Not starting as we're not running in a vm."
 		exit 0
@@ -56,8 +60,8 @@
 			modprobe vmxnet
 		fi
 
-		log_daemon_msg "Starting open-vm guest daemon" "guestd"
-		guestd --background /var/run/vmware-guestd.pid
+		log_daemon_msg "Starting open-vm guest daemon" "$GUESTD"
+		$GUESTD --background /var/run/vmware-guestd.pid
 		log_end_msg 0
 		;;
 
@@ -65,7 +69,7 @@
 		# Check if we're running inside VMWare
 		exit_if_not_in_vm
 
-		log_daemon_msg "Stopping open-vm guest daemon" "guestd"
+		log_daemon_msg "Stopping open-vm guest daemon" "$GUESTD"
 
 		if [ -f /var/run/vmware-guestd.pid ]
 		then

--- End Message ---
--- Begin Message ---
Source: open-vm-tools
Source-Version: 2008.02.13-77928-2

We believe that the bug you reported is fixed in the latest version of
open-vm-tools, which is due to be installed in the Debian FTP archive:

open-vm-source_2008.02.13-77928-2_all.deb
  to pool/contrib/o/open-vm-tools/open-vm-source_2008.02.13-77928-2_all.deb
open-vm-tools_2008.02.13-77928-2.diff.gz
  to pool/contrib/o/open-vm-tools/open-vm-tools_2008.02.13-77928-2.diff.gz
open-vm-tools_2008.02.13-77928-2.dsc
  to pool/contrib/o/open-vm-tools/open-vm-tools_2008.02.13-77928-2.dsc
open-vm-tools_2008.02.13-77928-2_i386.deb
  to pool/contrib/o/open-vm-tools/open-vm-tools_2008.02.13-77928-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[EMAIL PROTECTED]> (supplier of updated open-vm-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat,  8 Mar 2008 08:48:00 +0100
Source: open-vm-tools
Binary: open-vm-tools open-vm-source
Architecture: source i386 all
Version: 2008.02.13-77928-2
Distribution: unstable
Urgency: medium
Maintainer: Daniel Baumann <[EMAIL PROTECTED]>
Changed-By: Daniel Baumann <[EMAIL PROTECTED]>
Description: 
 open-vm-source - Source for VMware guest systems driver
 open-vm-tools - tools and components for VMware guest systems
Closes: 469146
Changes: 
 open-vm-tools (2008.02.13-77928-2) unstable; urgency=medium
 .
   * Rewriting copyright in machine-interpretable format.
   * Cleaned up copyright.
   * Fixing pathes and binary names in init script (Closes: #469146).
Files: 
 99afd4d563ee5c248d42db06f5dfe3d9 943 contrib/admin extra 
open-vm-tools_2008.02.13-77928-2.dsc
 3778331007158f2de0a4c3c960c03304 8229 contrib/admin extra 
open-vm-tools_2008.02.13-77928-2.diff.gz
 e14677755bb35ddcd834ea2bc22a5524 525170 contrib/admin extra 
open-vm-tools_2008.02.13-77928-2_i386.deb
 3155bcad025631bf7d6468928cea398c 418732 contrib/admin extra 
open-vm-source_2008.02.13-77928-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFH0kYJ+C5cwEsrK54RApm8AJ9zOH2EfnrUrHCbwSqIGD7D6Yx1ywCdHWI8
5jwO0KYXQFO2bP+TNrc4F3Q=
=t3RH
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to