Fabian Greffrath <[EMAIL PROTECTED]> writes: > Reinhard Tartler schrieb: >> If that works, I think we can drop the drop the sed surgery regarding >> Makefile.pic / config.mak.pic, I think. > > In this context I believe that the $(MAKE) calls in debian/rules are > implemented in a strange way... > > You know, we call MAKE twice; once to build the static libraries and > then again to build the shared libraries and the frontends. To build the > static libraries we call MAKE from the top source directory. Then we > backup the static libraries after compilation. Afterwards, to build the > shared libraries and the frontends, we go down into each of the > libraries' directories and call 'make clean && make' (roughly) there. > > Is this still necessary, given that we do not manipulate Makefile.pic > anymore, or could we simply run 'make clean && make' again from the top > source directory instead? If it is possible, we should do this for the > sake of clarity.
Yes, this is highly not obvious and should be cleaned up. > Another thing that I don't understand is, how it builds the ffmpeg > frontend (which it obviously does) if MAKE is only run inside the > subdirectories but not in the top directory... you mean the binary 'ffmpeg'? Well, it is built in the first step with the static version of ffmpeg, right? > > Yet another issue in the context of debian/rules: As long as we don't > run configure with --disable-optimizations, the {C,CXX,LD}FLAGS > environment variables that are set by dpkg-buildpackage are simply > ignored and overridden with dubious optimization flags in the range > between -O3 and -O5. I consider this unacceptable and believe, all > sources shuold be compiled with the same standard policy-conform set of > flags that is CFLAGS="-Wall -g -O2". Well, AFAIUI, there are many files in the ffmpeg source that need special compiler flags. TBH, I'm not interested in investing much time in reviewing the ffmpeg Makefiles. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]