Your message dated Sun, 03 Aug 2008 19:32:08 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#493349: fixed in libdbi-drivers 0.8.2-1-4.1
has caused the Debian Bug report #493349,
regarding libdbi-drivers: FTBFS in unstable due to utterly wrong lib checks
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
493349: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493349
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: libdbi-drivers
Version: 0.8.2-1-4
Severity: serious
Tags: sid patch

The libdbi-drivers package fails to build with freetds 0.82 in unstable,
because the upstream checks for libraries (in acinclude.m4) are absurd:

        if test "$ac_freetds_incdir" = "no" || test "$ac_freetds_libs" = "no"; 
then
                freetds_incdirs="/usr/include /usr/local/include"
                AC_FIND_FILE(tds.h, $freetds_incdirs, ac_freetds_incdir)
                freetds_libdirs="/usr/lib /usr/local/lib"
                AC_FIND_FILE(libtds.so, $freetds_libdirs, ac_freetds_libdir)
                if test "$ac_freetds_incdir" = "no"; then
                        AC_MSG_RESULT(no)
                        AC_MSG_ERROR([Invalid Freetds directory - include
                        files not found.])
                fi
                if test "$ac_freetds_libdir" = "no"; then
                        AC_MSG_RESULT(no)
                        AC_MSG_ERROR([Invalid Freetds directory - libraries
                        not found.])
                fi
        fi

AC_FIND_FILE() is the wrong thing.  We have compilers with system lib and
include paths, and autoconf macros AC_CHECK_HEADERS() and AC_CHECK_LIB()
which do the right thing with the compiler.  AC_FIND_FILE() here is
reinventing the wheel - poorly.

Besides which, this check uses AC_FIND_FILE() to look for a file *which is
never used in the build*.  libtds.so /was/ an internal library in previous
versions of FreeTDS, which has now been removed.  libdbi-drivers /never/
linked against this library; it linked against libct, which is the correct
public interface.  So it should be checking for the library it will actually
use!  (but using AC_CHECK_LIB(), not AC_FIND_FILE()!)

There is fortunately a way to bypass this wrong check by passing a
--with-freetds-dir argument to ./configure.  A patch to do this is attached.
Let me know if you would like me to upload this as an NMU.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[EMAIL PROTECTED]                                     [EMAIL PROTECTED]
diff -u libdbi-drivers-0.8.2-1/debian/rules libdbi-drivers-0.8.2-1/debian/rules
--- libdbi-drivers-0.8.2-1/debian/rules
+++ libdbi-drivers-0.8.2-1/debian/rules
@@ -20,7 +20,10 @@
 	cp /usr/share/misc/config.sub .
 	cp /usr/share/misc/config.guess .
 
-	./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --with-pgsql --with-mysql --with-sqlite --with-sqlite3 --with-freetds --enable-docs --enable-libdbi
+	./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
+		--prefix=/usr --with-pgsql --with-mysql --with-sqlite \
+		--with-sqlite3 --with-freetds --with-freetds-dir=/usr \
+		--enable-docs --enable-libdbi
 # This is for the moment removed until the upstream fixes the problems with
 # the new API: --with-firebird
 
diff -u libdbi-drivers-0.8.2-1/debian/changelog libdbi-drivers-0.8.2-1/debian/changelog
--- libdbi-drivers-0.8.2-1/debian/changelog
+++ libdbi-drivers-0.8.2-1/debian/changelog
@@ -1,3 +1,13 @@
+libdbi-drivers (0.8.2-1-4.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * High urgency upload for RC bugfix.
+  * Pass --freetds-inc-dir to configure, to bypass the ridiculous upstream
+    AC_FIND_FILE() checks for files that *aren't used during the build*;
+    fixes a build failure with FreeTDS 0.82.
+
+ -- Steve Langasek <[EMAIL PROTECTED]>  Sat, 02 Aug 2008 09:00:11 +0000
+
 libdbi-drivers (0.8.2-1-4) unstable; urgency=low
 
   * Updated the dbd_pgsql.c so it doesn't conflicts with the declaration of

--- End Message ---
--- Begin Message ---
Source: libdbi-drivers
Source-Version: 0.8.2-1-4.1

We believe that the bug you reported is fixed in the latest version of
libdbi-drivers, which is due to be installed in the Debian FTP archive:

libdbd-freetds_0.8.2-1-4.1_amd64.deb
  to pool/main/libd/libdbi-drivers/libdbd-freetds_0.8.2-1-4.1_amd64.deb
libdbd-mysql_0.8.2-1-4.1_amd64.deb
  to pool/main/libd/libdbi-drivers/libdbd-mysql_0.8.2-1-4.1_amd64.deb
libdbd-pgsql_0.8.2-1-4.1_amd64.deb
  to pool/main/libd/libdbi-drivers/libdbd-pgsql_0.8.2-1-4.1_amd64.deb
libdbd-sqlite3_0.8.2-1-4.1_amd64.deb
  to pool/main/libd/libdbi-drivers/libdbd-sqlite3_0.8.2-1-4.1_amd64.deb
libdbd-sqlite_0.8.2-1-4.1_amd64.deb
  to pool/main/libd/libdbi-drivers/libdbd-sqlite_0.8.2-1-4.1_amd64.deb
libdbi-drivers_0.8.2-1-4.1.diff.gz
  to pool/main/libd/libdbi-drivers/libdbi-drivers_0.8.2-1-4.1.diff.gz
libdbi-drivers_0.8.2-1-4.1.dsc
  to pool/main/libd/libdbi-drivers/libdbi-drivers_0.8.2-1-4.1.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve Langasek <[EMAIL PROTECTED]> (supplier of updated libdbi-drivers package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 02 Aug 2008 09:00:11 +0000
Source: libdbi-drivers
Binary: libdbd-sqlite libdbd-sqlite3 libdbd-mysql libdbd-pgsql libdbd-freetds
Architecture: source amd64
Version: 0.8.2-1-4.1
Distribution: unstable
Urgency: high
Maintainer: Thomas Goirand <[EMAIL PROTECTED]>
Changed-By: Steve Langasek <[EMAIL PROTECTED]>
Description: 
 libdbd-freetds - Freetds database server driver for libdbi
 libdbd-mysql - MySQL database server driver for libdbi
 libdbd-pgsql - PostgreSQL database server driver for libdbi
 libdbd-sqlite - SQLite database driver for libdbi
 libdbd-sqlite3 - SQLite3 database driver for libdbi
Closes: 493349
Changes: 
 libdbi-drivers (0.8.2-1-4.1) unstable; urgency=high
 .
   * Non-maintainer upload with maintainer's approval.
   * High urgency upload for RC bugfix.
   * Pass --freetds-inc-dir to configure, to bypass the ridiculous upstream
     AC_FIND_FILE() checks for files that *aren't used during the build*;
     fixes a build failure with FreeTDS 0.82.  Closes: #493349.
Checksums-Sha1: 
 4dc2885809c70065a310b681e2beb096ef0284c0 1245 libdbi-drivers_0.8.2-1-4.1.dsc
 1ce4b9d385b00aeed3338c7d4c686e44cc5d19c7 5396 
libdbi-drivers_0.8.2-1-4.1.diff.gz
 528072968bed5907422086f6125d56da32418df8 80130 
libdbd-sqlite_0.8.2-1-4.1_amd64.deb
 a6ca7b4f029225a9a5b8ee80f1295c9c2b31030b 81328 
libdbd-sqlite3_0.8.2-1-4.1_amd64.deb
 cdf40157b795c0caab41f054a7b7876abcbd4c86 63840 
libdbd-mysql_0.8.2-1-4.1_amd64.deb
 af6c12955131a4bc0337409ed8e8754603f896d9 113566 
libdbd-pgsql_0.8.2-1-4.1_amd64.deb
 2d1cb3d5ec9704902ea6df374e42ad4953af8692 17446 
libdbd-freetds_0.8.2-1-4.1_amd64.deb
Checksums-Sha256: 
 b94c3e26e3c5d990e9cfa063724397b32d9bcee86d07f6982d0c99a0455a8528 1245 
libdbi-drivers_0.8.2-1-4.1.dsc
 36d51d2adf01fe5827f15ff1f803cdcb3af08f60746388c36e8ee0b813ad6954 5396 
libdbi-drivers_0.8.2-1-4.1.diff.gz
 1820663abcd9c5cdd82e158bd6fdb42f85b9b8d18272dd8a3e24ec7875218489 80130 
libdbd-sqlite_0.8.2-1-4.1_amd64.deb
 0dd514d246db3583bc936bf961b8c7e7a3984d53d5dadcc8b25bd3e236bb3087 81328 
libdbd-sqlite3_0.8.2-1-4.1_amd64.deb
 5d9fc4df2f0b8d863219820e1d1f5d9ffd94d2f8e5df1fe350b87f7564860bb1 63840 
libdbd-mysql_0.8.2-1-4.1_amd64.deb
 db6fa640bc83175e8d8c4c7ab56fea6fbb46b0ad3304429f9cb06732bce0a76e 113566 
libdbd-pgsql_0.8.2-1-4.1_amd64.deb
 d549a881a0a391b0dcc63449363bc6cb6f434871eb4301916043df083510729f 17446 
libdbd-freetds_0.8.2-1-4.1_amd64.deb
Files: 
 c943a6b9f101f5198c6161fb50588105 1245 libs optional 
libdbi-drivers_0.8.2-1-4.1.dsc
 7d234cbb08b6698a717e7b66ad71aef1 5396 libs optional 
libdbi-drivers_0.8.2-1-4.1.diff.gz
 8717067eb9fedd1a8cec67c1790d03e8 80130 libs optional 
libdbd-sqlite_0.8.2-1-4.1_amd64.deb
 1a761b0ccdc067b6f8f63f84d49669cd 81328 libs optional 
libdbd-sqlite3_0.8.2-1-4.1_amd64.deb
 c05aab8fb6a9996cb8bf41a718e2dd61 63840 libs optional 
libdbd-mysql_0.8.2-1-4.1_amd64.deb
 a27af8e1d34e23101f05f6f6dc1fe3c4 113566 libs optional 
libdbd-pgsql_0.8.2-1-4.1_amd64.deb
 1668d0e11dbc1327bad93c3f152cd218 17446 libs optional 
libdbd-freetds_0.8.2-1-4.1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFIlgQVKN6ufymYLloRAjxyAKCP41LUVp2732kNR5gA2DJXXpbcPgCffCg8
ENQs+kC6Wps2DPUuaqduBj0=
=NsCn
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to