On Thu, Aug 14, 2008 at 10:14:27PM +0200, Gudjon I. Gudjonsson wrote:
> > With the latest files from mentors I get:
> >
> > [EMAIL PROTECTED]:~/comedi$ dpkg-source -x comedi_0.7.76-2.dsc
> > gpg: Signature made Thu 14 Aug 2008 06:04:03 PM IST using DSA key ID
> > F9DDB166 gpg: Can't check signature: public key not found
> > dpkg-source: error: File ./comedi_0.7.76-2.diff.gz has size 4358 instead of
> > expected 4369
> Please try again. It works perfectly for me.

Ok, downloaded new version. I had to make some minor adjustments:

1. Changed 'exludes' -> 'excludes' in the changelog.
2. Dropped dependencies on auto* for the comedi-source package, AFAICT 
they are not needed and can cause non-deterministic behaviour. 
Verified that it works fine in pbuilder chroot.
3. Used '<<' instead of '<' to specify the libtool dependency, it did 
not complain about the latter, but policy mentions '<<' and not '<'. 

Resulting patch to the previous version is attached. That would be 
acceptable for upload, however there is a problem when building the
comedi-modules package:

[EMAIL PROTECTED]:/tmp# m-a a-i comedi -l 2.6.26-1-686
.
Updated infos about 1 packages
Getting source for kernel version: 2.6.26-1-686
Kernel headers available in /lib/modules/2.6.26-1-686/build
[...]
/usr/bin/make -I/usr/src/modules/comedi/comedi -C /usr/src/linux 
M=/usr/src/modules/comedi/comedi CC="gcc-4.1 
-I/usr/src/modules/comedi/ \
                -I/usr/src/modules/comedi/include  " modules
make[6]: Entering directory `/usr/src/linux-headers-2.6.26-1-686'
  CC [M]  /usr/src/modules/comedi/comedi/comedi_fops.o
/usr/src/modules/comedi/comedi/comedi_fops.c: In function 
'comedi_init':
/usr/src/modules/comedi/comedi/comedi_fops.c:1918: error: implicit 
declaration of function 'class_device_create'
/usr/src/modules/comedi/comedi/comedi_fops.c:1918: warning: assignment 
makes pointer from integer without a cast
/usr/src/modules/comedi/comedi/comedi_fops.c: In function 
'comedi_cleanup':
/usr/src/modules/comedi/comedi/comedi_fops.c:1947: error: implicit 
declaration of function 'class_device_destroy'
make[7]: *** [/usr/src/modules/comedi/comedi/comedi_fops.o] Error 1
make[6]: *** [_module_/usr/src/modules/comedi/comedi] Error 2
make[6]: Leaving directory `/usr/src/linux-headers-2.6.26-1-686'
[...]

This error does not actually terminate the build, but kernel modules 
are not produced, so the comedi-modules package ends up empty. If you 
can reproduce it, please open another (RC) bug and we can move the 
discussion of this failure there.

Another problem I noticed is that something (not sure whether m-a or 
comedi) uses depmod when building comedi-modules. module-init-tools 
(which contains depmod) is not pulled in by any dependency. Please 
investigate, and if it is comedi which needs depmod, we'll need to add 
a dependency on module-init-tools.

Cheers.  
-- 
Jurij Smakov                                           [EMAIL PROTECTED]
Key: http://www.wooyd.org/pgpkey/                      KeyID: C99E03CC
diff -aur comedi-0.7.76.orig/debian/changelog comedi-0.7.76/debian/changelog
--- comedi-0.7.76.orig/debian/changelog	2008-08-15 14:42:04.000000000 +0100
+++ comedi-0.7.76/debian/changelog	2008-08-15 14:44:03.000000000 +0100
@@ -1,3 +1,13 @@
+comedi (0.7.76-2) unstable; urgency=low
+
+  * Cleanup for Lenny release
+  * Add version dependency < 2.0 to libtool 
+    (excludes version in experimental) (Closes: #488696)
+  * Bump standard version to 3.8.0, no changes needed
+  * Add Homepage field
+
+ -- Gudjon I. Gudjonsson <[EMAIL PROTECTED]>  Thu, 14 Aug 2008 18:59:55 +0200
+
 comedi (0.7.76-1) unstable; urgency=low
 
   * New upstream release
Only in comedi-0.7.76.orig/debian: comedi-modules.control
diff -aur comedi-0.7.76.orig/debian/control comedi-0.7.76/debian/control
--- comedi-0.7.76.orig/debian/control	2008-08-15 14:42:04.000000000 +0100
+++ comedi-0.7.76/debian/control	2008-08-15 14:44:19.000000000 +0100
@@ -3,12 +3,13 @@
 Priority: extra
 Maintainer: Gudjon I. Gudjonsson <[EMAIL PROTECTED]>
 Build-Depends: debhelper (>= 5), bzip2
-Standards-Version: 3.7.3
+Standards-Version: 3.8.0
+Homepage: http://www.comedi.org/
 
 Package: comedi-source
 Section: admin
 Architecture: all
-Depends: module-assistant, debhelper (>= 5), bzip2
+Depends: module-assistant, debhelper (>= 5), libtool (<< 2.0), bzip2
 Suggests: kernel-package, libcomedi0
 Description: Comedi kernel module source
  Comedi (Control and Measurement Device Interface) is a collection
diff -aur comedi-0.7.76.orig/debian/control.modules.in comedi-0.7.76/debian/control.modules.in
--- comedi-0.7.76.orig/debian/control.modules.in	2008-08-15 14:42:04.000000000 +0100
+++ comedi-0.7.76/debian/control.modules.in	2008-08-15 14:44:50.000000000 +0100
@@ -2,8 +2,9 @@
 Section: admin
 Priority: optional
 Maintainer: Gudjon I. Gudjonsson <[EMAIL PROTECTED]>
-Build-Depends: debhelper (>= 5), libtool, automake, autoconf, autotools-dev
-Standards-Version: 3.7.3
+Build-Depends: debhelper (>= 5), libtool (<< 2.0), automake, autoconf, autotools-dev
+Standards-Version: 3.8.0
+Homepage: http://www.comedi.org/
 
 Package: comedi-modules-_KVERS_
 Architecture: any

Reply via email to