tags 487101 patch
thanks

On Tue, Aug 12, 2008 at 07:08:35AM +0300, Kęstutis Biliūnas wrote:
> # reassign 487101 freetype

> Pr, 2008 08 11 23:42 +0100, Jurij Smakov rašė: 
> > Here's some additional debugging information, indicating that failure 
> > is actually in libfreetype6. I've built libfreetype6 with 
> > DEB_BUILD_OPTIONS='nostrip' (if I add 'noopt', then segmentation fault 
> > no longer triggers)

> Labai, labai ačiū Jurijau. Your info disclose the actual origin of
> this bug.

> I have reinstalled the libfreetype6{-dev}_2.2.1-5+etch2 packages and
> rebuilt the fontforge package. And yes, the problem disappeared. 
> So, there is some regression in the freetype package.

> Steve and others freetype package maintainers - please turn attention
> to this bug (I can't to reassign this bug, because I am no longer the
> maintainer of fontforge package). 

This is because of a lack of initialization of stream.  If FT_Stream_New()
fails, the memory is uninitialized and hilarity ensues.

After correcting this error with the attached patch, fontforge successfully
generates a set of .ttf files, so I guess this takes care of it (in spite of
the rather large number of warnings spit out by fontforge itself).

I'll check this patch against upstream to see if another solution has been
implemented there.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[EMAIL PROTECTED]                                     [EMAIL PROTECTED]
Index: freetype-2.3.7/src/base/ftobjs.c
===================================================================
--- freetype-2.3.7.orig/src/base/ftobjs.c
+++ freetype-2.3.7/src/base/ftobjs.c
@@ -1713,7 +1713,7 @@
     FT_Error     error;
     FT_Driver    driver;
     FT_Memory    memory;
-    FT_Stream    stream;
+    FT_Stream    stream = 0;
     FT_Face      face = 0;
     FT_ListNode  node = 0;
     FT_Bool      external_stream;

Reply via email to