Your message dated Wed, 10 Sep 2008 07:47:10 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#498394: fixed in gpicview 0.1.9-3 has caused the Debian Bug report #498394, regarding gpicview: Should not save unsupported types. to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 498394: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498394 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: gpicview Version: 0.1.9-2 Severity: grave Justification: causes non-serious data loss Tags: patch *** Please type your report below this line *** Save or auto-save on gif files will empty that file. It is because the gdk_pixbuf_save() is only supporting bmp/ico/jpeg/png/tiff currently. Other formats like gif/pcx/pnm/xbm/xpm... is not supported and if we directly call that function, it erases the file. The patch detects which formats are currently supported by gdk-pixbuf and only do the save on supported types. -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.26-1-686 (SMP w/1 CPU core) Locale: LANG=zh_TW.UTF-8, LC_CTYPE=zh_TW.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages gpicview depends on: ii libatk1.0-0 1.22.0-1 The ATK accessibility toolkit ii libc6 2.7-13 GNU C Library: Shared libraries ii libcairo2 1.6.4-6 The Cairo 2D vector graphics libra ii libglib2.0-0 2.16.5-1 The GLib library of C routines ii libgtk2.0-0 2.12.11-3 The GTK+ graphical user interface ii libjpeg62 6b-14 The Independent JPEG Group's JPEG ii libpango1.0-0 1.20.5-1 Layout and rendering of internatio ii libx11-6 2:1.1.4-2 X11 client-side library Versions of packages gpicview recommends: ii xdg-utils 1.0.2-6 desktop integration utilities from gpicview suggests no packages. -- no debconf information -- PaulLiu(劉穎駿) E-mail address: [EMAIL PROTECTED]Index: main-win.c =================================================================== --- main-win.c (revision 848) +++ main-win.c (working copy) @@ -1285,6 +1285,9 @@ gboolean main_win_save( MainWin* mw, const char* file_path, const char* type, gboolean confirm ) { + gboolean result1,gdk_save_supported; + GSList *gdk_formats; + GSList *gdk_formats_i; if( ! mw->pix ) return FALSE; @@ -1306,13 +1309,38 @@ } } + /* detect if the current type can be save by gdk_pixbuf_save() */ + gdk_save_supported = FALSE; + gdk_formats = gdk_pixbuf_get_formats(); + for (gdk_formats_i = gdk_formats; gdk_formats_i; + gdk_formats_i = g_slist_next(gdk_formats_i)) + { + GdkPixbufFormat *data; + data = gdk_formats_i->data; + if (gdk_pixbuf_format_is_writable(data)) + { + if ( strcmp(type, gdk_pixbuf_format_get_name(data))==0) + { + gdk_save_supported = TRUE; + break; + } + } + } + g_slist_free (gdk_formats); + GError* err = NULL; - if( ! gdk_pixbuf_save( mw->pix, file_path, type, &err, NULL ) ) + if (!gdk_save_supported) { + /* FIXME: we should show some error messages here when the type + is not supported to save */ + return FALSE; + } + result1 = gdk_pixbuf_save( mw->pix, file_path, type, &err, NULL ); + if( ! result1 ) + { main_win_show_error( mw, err->message ); return FALSE; } - return TRUE; }
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---Source: gpicview Source-Version: 0.1.9-3 We believe that the bug you reported is fixed in the latest version of gpicview, which is due to be installed in the Debian FTP archive: gpicview_0.1.9-3.diff.gz to pool/main/g/gpicview/gpicview_0.1.9-3.diff.gz gpicview_0.1.9-3.dsc to pool/main/g/gpicview/gpicview_0.1.9-3.dsc gpicview_0.1.9-3_i386.deb to pool/main/g/gpicview/gpicview_0.1.9-3_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Andrew Lee <[EMAIL PROTECTED]> (supplier of updated gpicview package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Wed, 10 Sep 2008 09:40:53 +0800 Source: gpicview Binary: gpicview Architecture: source i386 Version: 0.1.9-3 Distribution: unstable Urgency: high Maintainer: Andrew Lee <[EMAIL PROTECTED]> Changed-By: Andrew Lee <[EMAIL PROTECTED]> Description: gpicview - lightweight image viewer Closes: 498394 Changes: gpicview (0.1.9-3) unstable; urgency=high . * Applied detect_format_before_save_0.1.9.dpatch to close a RC bug. set urgency=high (Closes: #498394) Thanks PaulLiu(劉穎駿) <[EMAIL PROTECTED]> for the patch. Checksums-Sha1: 70af8695b791dfe5b0618ee2850912891ebd3e8b 1037 gpicview_0.1.9-3.dsc da216cd7428b176310372900c228f6206e174796 4625 gpicview_0.1.9-3.diff.gz acdad109c0222c1dcd00f81433a8c875f940cb4a 46400 gpicview_0.1.9-3_i386.deb Checksums-Sha256: fd6f0346af57fc09b4e73cc1a141375b1d7108f27526afa6e92f5452b6368486 1037 gpicview_0.1.9-3.dsc 1d333b0adf65f6670529af276a26f04d85aab26e819b03ebb5aa7f553747952e 4625 gpicview_0.1.9-3.diff.gz 7ba9a6b04bb2f2ac0dd8af88b0262e082b7d403b3207a2048f6bbec15071d0d6 46400 gpicview_0.1.9-3_i386.deb Files: 205481e079cab31a28a39e06d5219932 1037 graphics optional gpicview_0.1.9-3.dsc 26b0e918706581988dc3285919774a87 4625 graphics optional gpicview_0.1.9-3.diff.gz a10fb3ed6f8f312654375b000150c364 46400 graphics optional gpicview_0.1.9-3_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjHePoACgkQnQYz4bYlCYUCjACdHflvg+0Z/RzwHhPxDff2vkpP tZsAnjJD9U5VSLbBTyfqxIoqdxVG5kmk =VFXu -----END PGP SIGNATURE-----
--- End Message ---
