Comparing this bug with the others from which it was cloned, I've
implemented a small patch to ensure that the value returned by
Gpm_GetEvent is checked to be positive one before allowing the code to
proceed.

$ debdiff orig/aalib_1.4p5-37.dsc aalib_1.4p5-37.1.dsc

diff -u aalib-1.4p5/debian/changelog
aalib-1.4p5/debian/changelog
--- aalib-1.4p5/debian/changelog
+++ aalib-1.4p5/debian/changelog
@@ -1,3 +1,11 @@
+aalib (1.4p5-37.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Ensure that aalib checks the value returned by Gpm_GetEvent()
+    and only proceeds if value == 1 (Closes: #506718)
+
+ -- Neil Williams <[EMAIL PROTECTED]>  Sat, 29 Nov 2008 18:55:52
+0100 +
 aalib (1.4p5-37) unstable; urgency=low
 
   * New maintainer.  Closes: #482480.
only in patch2:
unchanged:
--- aalib-1.4p5.orig/debian/patches/10-gpm-geteventcheck.diff
+++ aalib-1.4p5/debian/patches/10-gpm-geteventcheck.diff
@@ -0,0 +1,11 @@
+--- ../orig/aalib-1.4p5/src/aaslnkbd.c 2001-04-26
17:03:44.000000000 +0200 ++++ src/aaslnkbd.c    2008-11-29
19:03:18.000000000 +0100 +@@ -124,7 +124,7 @@
+           return (AA_NONE);
+       }
+       if ((gpm_fd > -1) && (FD_ISSET(gpm_fd, &readfds))) {
+-          if (Gpm_GetEvent(&ev) && gpm_handler
++          if ((Gpm_GetEvent(&ev) == 1) && gpm_handler
+               && ((*gpm_handler) (&ev, gpm_data))) {
+               gpm_hflag = 1;
+               return AA_MOUSE;

If someone is able to test that this actually fixes the bug, I'm happy
to proceed.

-- 


Neil Williams
=============
http://www.data-freedom.org/
http://www.linux.codehelp.co.uk/
http://e-mail.is-not-s.ms/

Attachment: pgpxvHEIVJ3LY.pgp
Description: PGP signature

Reply via email to