Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit
On 18 November 2009 at 18:55, Robert Edmonds wrote: | [ kenton varda, upstream release engineer for protobuf, added to Cc. ] | | Dirk Eddelbuettel wrote: | > I am not sure what the best way forward is. Given that mumble is the only | > user of protobuf, could you just rebuild based on the protobuf? That is | > probably quicker than a new upload, NEW queue, required rebuild, ... and | > avoids all hazzles regarding soname conflicts if we move to 5 now and Google | > later claims 5. | | since the changes from 2.1.0 to 2.2.0 have demonstrably broken ABI | compatibility, the SONAME really should be bumped, regardless of NEW | delays, etc. because it is the correct thing to do, rather than breaking | unrelated software. ideally it should be coordinated with upstream so | that we don't break binary compatibility with other linux distributions | (to the extent that this is possible with the C++ ABI, which i am not | especially familiar with). That is correct if you narrowly play by the book, but in the grand scheme of things it is still somewhat silly that among 8k or 9k source packages we do these dances for packages whose 'dependency graph' has one edge and one further package. Anyway, it's moving the right way and Debian finally gets a proper 2.2 version of ProtoBuf. Kenton, nice to meet you -- a co-author and I will contact you in a bit about a neat new ProtoBuf language binding for GNU R with pretty nice reflection etc pp. Had I know that your plan was to bump sonames each times I would have contacted you late week / this weekend while I prepared this release stepping in for the nominal maintainer Iusty. | kenton, is it possible to make a 2.2.1 release with just a SONAME bump? | see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=556563 for the | relevant justification: | | m...@exez:~$ mumble | mumble: Symbol `_ZTIN6google8protobuf7MessageE' has different size in shared object, consider re-linking | mumble: symbol lookup error: mumble: undefined symbol: _ZN6google8protobuf14MessageFactory29InternalRegisterGeneratedFileEPKcPFvvE | | i've also noticed that these changes break the protobuf-c package (for | which i am the debian maintainer): | | edmo...@chase{0}:~$ protoc-c | protoc-c: symbol lookup error: /usr/lib/libprotoc.so.4: undefined symbol: _ZN6google8protobuf8internal10WireFormat21kWireTypeForFieldTypeE | | i think protobuf-c and mumble are the only two reverse dependencies of | protobuf, and they're both broken by the 2.2.0-0.1 upload. | | the protobuf debian package unfortunately lacks .symbols files for | libprotocN and libprotobufN, which would have caught this problem. | when .symbols files are in use, the package build should fail if there | are any symbol insertions or deletions. | | i've rebuilt the debian protobuf 2.1.0-1 package, adding symbol files, | and then used the result to rebuild the 2.2.0-0.1 package, which reveals | that there are quite a few missing symbols in 2.2.0: | | edmo...@chase{0}:~/debian/protobuf/symbols/protobuf-2.2.0/debian$ grep _ZN6google8protobuf14MessageFactory29InternalRegisterGeneratedFileEPKcPFvvE *.symbols | libprotobuf4.symbols:#MISSING: 2.2.0# _zn6google8protobuf14messagefactory29internalregistergeneratedfileepkcpf...@base 2.1.0 | | (the missing symbol that broke mumble.) | | edmo...@chase{0}:~/debian/protobuf/symbols/protobuf-2.2.0/debian$ grep MISSING *.symbols | wc -l | 311 | | (310 other symbols are missing as well.) | | i've attached the revelant diff.gz's. | | btw, 2.2.0 introduced a new 'libprotobuf-lite' library which should be | split out of the libprotobuf binary package, since (i gather) the idea | is to have a lite version of the library which doesn't require the full | heft of libprotobuf. Feel free to patch this, or wait for Iustin to come back to action. Dirk | | -- | Robert Edmonds | edmo...@debian.org | | [GNUPG:] ERRSIG 769FBF4873014091 17 2 01 1258588503 9 | [GNUPG:] NO_PUBKEY 769FBF4873014091 -- Three out of two people have difficulties with fractions. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
