Hi Anders, On Thu, Apr 29, 2010 at 03:20:41AM -0400, Anders Kaseorg wrote:
How can you suggest that a multiword CC is “abuse” and okay to break, when by your own logic (bug 523642), CDBS “has a well defined current behaviour that users rely on”?
Because I am stupid and unworthy? Please do not hide complaints as questions.
the CDBS change that introduced this regression (commit ee9bbf5 in version 0.4.77) doesn’t even correctly do what it was _intended_ to do. The $(origin) function is supposed to be called with a variable name, not with the contents of a variable.
Thanks a bunch for spotting this.I am aware of the special way $(origin) use variables, and I _did_ test that it actually worked when implementing it, but obviously I did a
mistake anyway when applying :-P
So, can you please apply this patch, which fixes both of these bugs and should make everyone happy?
Most certainly. Thanks a lot for the investigation and patch! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: Digital signature
