block 590827 with 589103 thanks On 07/29/2010 11:47 AM, Petr Salinger wrote: > Package: xdotool > Version: 1:2.20100602.2915-1 > Severity: serious > Tags: patch > User: [email protected] > Usertags: kfreebsd > > > Hi, > > the current version fails to build on GNU/kFreeBSD. > It looks like lsof is needed on for testsuite.
#589103 is a bug against lsof to make that tool available on for the
kFreeBSDs (and hurd, if possible). lsof does work on regular FreeBSD
systems. debian GNU/kFreeBSD shouldn't be deprived of the tool.
> Please restrict it's b-d only on linux "lsof [linux-any]"
> and allow missing lsof in t/ephemeral-x.sh script.
[...]
> --- xdotool-2.20100701.2961.orig/t/ephemeral-x.sh
> +++ xdotool-2.20100701.2961/t/ephemeral-x.sh
> @@ -69,7 +69,7 @@ fi
> if ! which lsof > /dev/null 2>&1 ; then
> echo "Unable to find lsof. This is a required tool."
> cleanup
> - exit 1
> + exit 0
> fi
I don't think this is an acceptable solution, because it breaks the test
scripts (they actually rely on lsof, the check for their presence isn't
superfluous)
--dkg
signature.asc
Description: OpenPGP digital signature
