Package: rioutil
Version: 1.4.4-1
Severity: serious
Tags: patch

rioutil fails to build because it contains an invalid lvalue in an
assignment:

> source='rio.c' object='rio.lo' libtool=yes \
> depfile='.deps/rio.Plo' tmpdepfile='.deps/rio.TPlo' \
> depmode=gcc3 /bin/sh ../depcomp \
> /bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../include 
> -I../include    -g3 -c -o rio.lo `test -f 'rio.c' || echo './'`rio.c
> mkdir .libs
>  gcc -DHAVE_CONFIG_H -I. -I. -I../include -I../include -g3 -c rio.c -MT 
> rio.lo -MD -MP -MF .deps/rio.TPlo  -fPIC -DPIC -o .libs/rio.o
...
> rio.c: In function 'get_flist_riohd':
> rio.c:376: error: invalid lvalue in assignment
...

The attached patch fixes this problem by making the first cast apply
to the result of the assignment instead of the lvalue.

-- 
Matt
only in patch2:
unchanged:
--- rioutil-1.4.4.orig/librioutil/rio.c
+++ rioutil-1.4.4/librioutil/rio.c
@@ -373,7 +373,7 @@
     return ret;
   }
 
-  iptr = (u_int32_t *)read_buffer = (u_int8_t *) malloc (RIO_FTS);
+  iptr = (u_int32_t *)(read_buffer = (u_int8_t *) malloc (RIO_FTS));
   if (read_buffer == NULL) {
     rio_log (rio, errno, "Could not allocate read buffer\n");
     return errno;

Attachment: signature.asc
Description: Digital signature

Reply via email to