2011/1/24 Harald Jenny <har...@a-little-linux-box.at>: > Ok although the PIDFILE line can be removed with the below code.
I'm don't see where PIDFILE is removed. >> Yes. It should be a valid config if /etc/default/$NAME that doesn't >> contain anything. Actually it should be the default to have only >> comments with the default values that the SysAdmin should be able to >> change with custom values. I don't know what you have now in the >> default config. > > Well it's actually this way but PIDFILE needs to be set explicitly for the > --pidfile option in the start-stop-daemon stanza - the binary itself already > has the default path hardcoded. >> One more important issue I think we missed so far is to have >> MILTERSOCKET empty in the config file. I think you covered only to >> skip "chmod+chown" but in fact it should abort execution. So this >> construction: I was wrong here. MILTERSOCKET can be empty in the config from /etc/default/$NAME and this should be the default. > Not really as there is a default value set in the binary which points to > /var/lib/amavis/amavisd-milter.sock - I guess I should rather do: > > if [ -z "$MILTERSOCKET" ]; then > MILTERSOCKETTYPE=pipe > else > [..] > fi > > as this would allow to also set MILTERSOCKETOWNER and MILTERSOCKETMODE with > the > default pipe location - what do you think? I think the above test is always false if you correctly initialize MILTERSOCKET after the /etc/default/$NAME has been sourced. [ -z "$MILTERSOCKET" ] || MILTERSOCKET="/var/lib/amavis/amavisd-milter.sock" Later on you don't check if it's empty but only the type: unix vs inet. Thanks -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
