Your message dated Wed, 05 Oct 2011 16:02:11 +0000
with message-id <e1rbtv9-00089o...@franck.debian.org>
and subject line Bug#644336: fixed in leveldb 0+20110926.git26db4d9-2
has caused the Debian Bug report #644336,
regarding leveldb: ./port/atomic_pointer.h:161:3: error: expected
primary-expression before 'volatile'
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
644336: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=644336
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: leveldb
Version: 0+20110926.git26db4d9-1
Severity: serious
Justification: fails to build from source
Tags: patch
Hi,
leveldb ftbfs on s390.
https://buildd.debian.org/status/fetch.php?pkg=leveldb&arch=s390&ver=0%2B20110926.git26db4d9-1&stamp=1317749307
-----
In file included from ./port/port_posix.h:28:0,
from ./port/port.h:14,
from ./db/filename.h:14,
from db/builder.cc:7:
./port/atomic_pointer.h: In function 'void leveldb::port::ReadMemoryBarrier()':
./port/atomic_pointer.h:161:3: error: expected primary-expression
before 'volatile'
./port/atomic_pointer.h:161:3: error: expected ';' before 'volatile'
./port/atomic_pointer.h: In function 'void leveldb::port::WriteMemoryBarrier()':
./port/atomic_pointer.h:164:3: error: expected primary-expression
before 'volatile'
./port/atomic_pointer.h:164:3: error: expected ';' before 'volatile'
make[1]: *** [db/builder.o] Error 1
make[1]: *** Waiting for unfinished jobs....
-----
Because there is not asm keyword in front of volatile.
(Sorry, this patch was provided by me.)
I created new patch. Please check and apply.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
From bc03fac68e487d0aa367b93794177178a1f9f1ab Mon Sep 17 00:00:00 2001
From: Nobuhiro Iwamatsu <iwama...@debian.org>
Date: Wed, 28 Sep 2011 12:29:28 +0900
Subject: [PATCH 5/9] Add support S390
Signed-off-by: Nobuhiro Iwamatsu <iwama...@debian.org>
---
port/atomic_pointer.h | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/port/atomic_pointer.h b/port/atomic_pointer.h
index 6d0b15f..03a1815 100644
--- a/port/atomic_pointer.h
+++ b/port/atomic_pointer.h
@@ -42,6 +42,8 @@
#define ARCH_CPU_IA64_FAMILY 1
#elif defined(__alpha__)
#define ARCH_CPU_ALPHA_FAMILY 1
+#elif defined(__s390x__) || defined(__s390__)
+#define ARCH_CPU_S390_FAMILY 1
#endif
namespace leveldb {
@@ -144,6 +146,17 @@ inline void WriteMemoryBarrier() {
}
#define LEVELDB_HAVE_MEMORY_BARRIER
+// S390
+#elif defined(ARCH_CPU_S390_FAMILY)
+
+inline void ReadMemoryBarrier() {
+ asm volatile("bcr 15,0" : : : "memory");
+}
+inline void WriteMemoryBarrier() {
+ asm volatile("bcr 15,0" : : : "memory");
+}
+#define LEVELDB_HAVE_MEMORY_BARRIER
+
#endif
// AtomicPointer built using platform-specific MemoryBarrier()
@@ -201,6 +214,7 @@ class AtomicPointer {
#undef ARCH_CPU_PPC_FAMILY
#undef ARCH_CPU_IA64_FAMILY
#undef ARCH_CPU_ALPHA_FAMILY
+#undef ARCH_CPU_S390_FAMILY
} // namespace leveldb::port
} // namespace leveldb
--
1.7.6.3
--- End Message ---
--- Begin Message ---
Source: leveldb
Source-Version: 0+20110926.git26db4d9-2
We believe that the bug you reported is fixed in the latest version of
leveldb, which is due to be installed in the Debian FTP archive:
leveldb-doc_0+20110926.git26db4d9-2_all.deb
to main/l/leveldb/leveldb-doc_0+20110926.git26db4d9-2_all.deb
leveldb_0+20110926.git26db4d9-2.debian.tar.gz
to main/l/leveldb/leveldb_0+20110926.git26db4d9-2.debian.tar.gz
leveldb_0+20110926.git26db4d9-2.dsc
to main/l/leveldb/leveldb_0+20110926.git26db4d9-2.dsc
libleveldb-dev_0+20110926.git26db4d9-2_amd64.deb
to main/l/leveldb/libleveldb-dev_0+20110926.git26db4d9-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 644...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alessio Treglia <ales...@debian.org> (supplier of updated leveldb package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 05 Oct 2011 17:45:43 +0200
Source: leveldb
Binary: libleveldb-dev leveldb-doc
Architecture: source amd64 all
Version: 0+20110926.git26db4d9-2
Distribution: unstable
Urgency: low
Maintainer: Alessio Treglia <ales...@debian.org>
Changed-By: Alessio Treglia <ales...@debian.org>
Description:
leveldb-doc - LevelDB documentation
libleveldb-dev - fast key-value storage library
Closes: 644336
Changes:
leveldb (0+20110926.git26db4d9-2) unstable; urgency=low
.
* debian/patches/0005-Add-support-S390.patch:
- Small fix to prevent FTBFS (Closes: #644336).
Checksums-Sha1:
3f727d517eb479c19171b415957d047fc763e5e1 1361
leveldb_0+20110926.git26db4d9-2.dsc
bd81c13ac081dde7d08c09ec24e42c019ee349ff 7234
leveldb_0+20110926.git26db4d9-2.debian.tar.gz
905cfc17e9251de5995024aeb3c3d6a6b034fd23 192316
libleveldb-dev_0+20110926.git26db4d9-2_amd64.deb
85a506fb02728b3e3b36cced07d06321c8ef945e 32698
leveldb-doc_0+20110926.git26db4d9-2_all.deb
Checksums-Sha256:
634a03e4422152e401230635c84741994fdb3695600fe05424a9be2b8e8d94c2 1361
leveldb_0+20110926.git26db4d9-2.dsc
a5d470b71f1196fe543fd1e99d31733e3662f40ae5e4f96da0c42a62adc8f368 7234
leveldb_0+20110926.git26db4d9-2.debian.tar.gz
ffb6a1524737d5fb666807959e521ce39187fe7967dbae0e3c608df24d569a30 192316
libleveldb-dev_0+20110926.git26db4d9-2_amd64.deb
241c169044dee2bd773aed67db28721a501e7aea649ffa614d98e39a79d63cdf 32698
leveldb-doc_0+20110926.git26db4d9-2_all.deb
Files:
ac74aeffcc266984342331ee764da3ab 1361 database optional
leveldb_0+20110926.git26db4d9-2.dsc
62b20221af0b9db860d884f8f31d2253 7234 database optional
leveldb_0+20110926.git26db4d9-2.debian.tar.gz
3e440b4bdae8737c2f140baa7e82054d 192316 libdevel optional
libleveldb-dev_0+20110926.git26db4d9-2_amd64.deb
d63b305355deb24bbfd333082390fe88 32698 doc optional
leveldb-doc_0+20110926.git26db4d9-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk6MfGsACgkQRdSMfNz8P9Dh5ACeN9xyF2W7i1ahmM3r6VJbN7+O
ancAn3zsgIPidkm1M5tOMi7OOm8UeTeo
=O4BN
-----END PGP SIGNATURE-----
--- End Message ---
