On Thu, Nov 24, 2011 at 6:29 AM, Florian Schlichting <fschl...@zedat.fu-berlin.de> wrote: > David, Antonio, Eric: > > On Sat, Sep 10, 2011 at 09:45:17AM +0100, David Woodhouse wrote: >> On Sat, 2011-09-10 at 15:52 +0800, Antonio Borneo wrote: >> > >> > In the fix you provide, >> > 1) you add ";s/ipid 0x....//g" at the end of string. >> > This does not impact backward compatibility. I'm in favour to >> > commit it. >> >> It's not suHi Florian,fficient. We originally had this in the >> vpnc-scripts.git >> repository¹ since about May, but then the iproute command grew *more* >> unrecognised output options so we have since changed it to be 'opt-in' >> instead of 'opt-out'². > >> ¹ http://git.infradead.org/users/dwmw2/vpnc-scripts.git/shortlog >> ² http://git.infradead.org/users/dwmw2/vpnc-scripts.git/commitdiff/4deaaf9a32 > > is there a reason why this improved patch should not be applied to SVN > as well as to the Debian package of vpnc? Corrected for fuzz, that would > be
Hi Florian, no reason, should be applied. I'll commit it in the weekend. Best Regards Antonio > > --- a/vpnc-script.in > +++ b/vpnc-script.in > @@ -116,7 +116,8 @@ destroy_tun_device() { > > if [ -n "$IPROUTE" ]; then > fix_ip_get_output () { > - sed 's/cache//;s/metric \?[0-9]\+ [0-9]\+//g;s/hoplimit > [0-9]\+//g' > + sed -e 's/ /\n/g' | \ > + sed -ne '1p;/via/{N;p};/dev/{N;p};/src/{N;p};/mtu/{N;p}' > } > > set_vpngateway_route() { > > >> I was just thinking that I should submit a patch which removes the >> out-of-date script from vpnc altogether. There have been a number of >> other fixes in the git tree too. > > What do you mean "remove" the script from vpnc - how would routes pushed > from the concentrator be configured on the client without this script? > > > From my point of view, vpnc without this patch is severely broken - it's > not just "not working", it also leaves networking in a non-working state > after it has been terminated regularly. Ubuntu managed to release with > the version currently in Debian, which causes some trouble to support, > and I'd like to make sure that the version in Debian at least works on > Debian when Ubuntu syncs for their upcoming LTS release. > > Florian > > > > -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org