Dear maintainer,

I've prepared an NMU for open-invaders (versioned as 0.3-3.1). The diff
is attached to this message.

Regards.

diff -Nru open-invaders-0.3/debian/changelog open-invaders-0.3/debian/changelog
--- open-invaders-0.3/debian/changelog	2011-09-03 22:05:26.000000000 +0200
+++ open-invaders-0.3/debian/changelog	2011-12-04 12:48:04.000000000 +0100
@@ -1,3 +1,13 @@
+open-invaders (0.3-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "FTBFS: ending.cc:218:128: error: format not a string literal
+    and no format arguments [-Werror=format-security]" by adding the patch from Ilya Barygin
+    (Closes: #643450)
+  * Urgency set to medium
+
+ -- Alexander Reichle-Schmehl <toli...@debian.org>  Sun, 04 Dec 2011 12:47:26 +0100
+
 open-invaders (0.3-3) unstable; urgency=low
 
   * debian/patches/fix_pmask_amd64.patch:
diff -Nru open-invaders-0.3/debian/patches/format-security.patch open-invaders-0.3/debian/patches/format-security.patch
--- open-invaders-0.3/debian/patches/format-security.patch	1970-01-01 01:00:00.000000000 +0100
+++ open-invaders-0.3/debian/patches/format-security.patch	2011-12-04 12:47:03.000000000 +0100
@@ -0,0 +1,185 @@
+Description: fix -Wformat-security warnings
+Author: Ilya Barygin <randomact...@ubuntu.com>
+
+--- open-invaders-0.3.orig/src/ending.cc
++++ open-invaders-0.3/src/ending.cc
+@@ -215,7 +215,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,40,(lines*22)+40,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,40,(lines*22)+40,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -232,7 +232,7 @@ void game_ending()
+ 		{
+ 			for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 			{
+-				textprintf_ex(screen,gamefont,80,((lines-19)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++				textprintf_ex(screen,gamefont,80,((lines-19)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 				delay_with_duh_poll(20,endsongplayer);
+ 			}
+ 		}
+@@ -248,7 +248,7 @@ void game_ending()
+ 			
+ 			for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 			{
+-				textprintf_ex(screen,gamefont,80,texty,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++				textprintf_ex(screen,gamefont,80,texty,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 				delay_with_duh_poll(20,endsongplayer);
+ 			}
+ 			
+@@ -263,7 +263,7 @@ void game_ending()
+ 			
+ 			for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 			{
+-				textprintf_ex(screen,gamefont,80,texty,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++				textprintf_ex(screen,gamefont,80,texty,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 				delay_with_duh_poll(20,endsongplayer);
+ 			}
+ 			
+@@ -275,7 +275,7 @@ void game_ending()
+ 	
+ 	for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 	{
+-		textprintf_ex(screen,gamefont,80,378,makecol16(255,255,255),0,endinglines[23].substr(0,individualchars).c_str());
++		textprintf_ex(screen,gamefont,80,378,makecol16(255,255,255),0,"%s",endinglines[23].substr(0,individualchars).c_str());
+ 		delay_with_duh_poll(20,endsongplayer);
+ 	}
+ 	
+@@ -287,7 +287,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,80,420,makecol16(255,255,255),0,endinglines[24].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,80,420,makecol16(255,255,255),0,"%s",endinglines[24].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -302,7 +302,7 @@ void game_ending()
+ 	
+ 	for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 	{
+-		textprintf_ex(screen,gamefont,340,250,makecol16(255,255,255),0,endinglines[25].substr(0,individualchars).c_str());
++		textprintf_ex(screen,gamefont,340,250,makecol16(255,255,255),0,"%s",endinglines[25].substr(0,individualchars).c_str());
+ 		delay_with_duh_poll(20,endsongplayer);
+ 	}
+ 	
+@@ -316,7 +316,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,80,((lines-19)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,80,((lines-19)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -331,7 +331,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,160,((lines-19)*22)+50,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,160,((lines-19)*22)+50,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+@@ -347,7 +347,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,80,((lines-19)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,80,((lines-19)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -362,7 +362,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,80,((lines-20)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,80,((lines-20)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -377,7 +377,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,230,((lines-24)*22)+10,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,230,((lines-24)*22)+10,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -392,7 +392,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,400,((lines-26)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,400,((lines-26)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -407,7 +407,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,400,((lines-27)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,400,((lines-27)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -422,7 +422,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,350,((lines-37)*22)+120,makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,350,((lines-37)*22)+120,makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -437,7 +437,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,40,((lines-38)*22),makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,40,((lines-38)*22),makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -452,7 +452,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,70,((lines-41)*22),makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,70,((lines-41)*22),makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
+@@ -465,7 +465,7 @@ void game_ending()
+ 		
+ 	for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 	{
+-		textprintf_ex(screen,gamefont,155,200,makecol16(255,255,255),0,endinglines[53].substr(0,individualchars).c_str());
++		textprintf_ex(screen,gamefont,155,200,makecol16(255,255,255),0,"%s",endinglines[53].substr(0,individualchars).c_str());
+ 		delay_with_duh_poll(20,endsongplayer);
+ 	}
+ 	
+@@ -477,7 +477,7 @@ void game_ending()
+ 		
+ 	for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 	{
+-		textprintf_ex(screen,gamefont,210,330,makecol16(255,255,255),0,endinglines[54].substr(0,individualchars).c_str());
++		textprintf_ex(screen,gamefont,210,330,makecol16(255,255,255),0,"%s",endinglines[54].substr(0,individualchars).c_str());
+ 		delay_with_duh_poll(20,endsongplayer);
+ 	}
+ 	
+@@ -491,7 +491,7 @@ void game_ending()
+ 		
+ 		for(int individualchars=0; individualchars<textlength+1; individualchars++)
+ 		{
+-			textprintf_ex(screen,gamefont,195,((lines-47)*22),makecol16(255,255,255),0,endinglines[lines].substr(0,individualchars).c_str());
++			textprintf_ex(screen,gamefont,195,((lines-47)*22),makecol16(255,255,255),0,"%s",endinglines[lines].substr(0,individualchars).c_str());
+ 			delay_with_duh_poll(20,endsongplayer);
+ 		}
+ 	}
diff -Nru open-invaders-0.3/debian/patches/series open-invaders-0.3/debian/patches/series
--- open-invaders-0.3/debian/patches/series	2011-09-03 22:06:54.000000000 +0200
+++ open-invaders-0.3/debian/patches/series	2011-12-04 12:47:03.000000000 +0100
@@ -1,2 +1,3 @@
 fix_ftbfs_gcc45.patch
 fix_pmask_amd64.patch
+format-security.patch

Reply via email to